Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: chrome/android/java/res/layout/autofill_credit_card_editor.xml

Issue 2109643003: Add billing address to masked server credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Delete AutofillServerCardPreferences.java Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/autofill_credit_card_editor.xml
diff --git a/chrome/android/java/res/layout/autofill_credit_card_editor.xml b/chrome/android/java/res/layout/autofill_credit_card_editor.xml
index 19fd877105542e0a90f935d0ee3bde334cf0793b..1dd466293749a5cc2b12103c366fabc26cb32f4e 100644
--- a/chrome/android/java/res/layout/autofill_credit_card_editor.xml
+++ b/chrome/android/java/res/layout/autofill_credit_card_editor.xml
@@ -10,6 +10,60 @@
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto" >
+ <!-- The section that's shown only for server cards. -->
gone 2016/06/29 20:09:41 One big problem with jamming in the controls into
please use gerrit instead 2016/06/30 01:19:27 Layouts are split-up.
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/server_card_label"
+ android:layout_width="wrap_content"
gone 2016/06/29 20:09:41 match_parent
please use gerrit instead 2016/06/30 01:19:27 Done.
+ android:layout_height="wrap_content"
+ style="@style/PreferenceTitle"
+ android:text="Visa 3832" />
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/server_card_sublabel"
+ android:layout_width="wrap_content"
gone 2016/06/29 20:09:42 match_parent
please use gerrit instead 2016/06/30 01:19:27 Done.
+ android:layout_height="wrap_content"
+ style="@style/PreferenceSummary"
+ android:text="08/2017" />
+
+ <LinearLayout
+ android:id="@+id/server_card_edit_link_container"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:paddingTop="@dimen/pref_autofill_field_top_padding"
+ android:paddingBottom="@dimen/pref_autofill_field_top_padding"
+ android:orientation="horizontal"
+ android:baselineAligned="false" >
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:paddingEnd="15dp"
+ android:layout_weight="1"
+ style="@style/PreferenceTitle"
+ android:text="@string/autofill_from_google_account_long" />
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/server_card_edit_link"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:textColor="?android:attr/textColorLink"
+ android:textAllCaps="true"
+ android:text="@string/autofill_wallet_management_link_text" />
+
+ </LinearLayout>
+
+ <org.chromium.ui.widget.ButtonCompat
gone 2016/06/29 20:09:41 This button is just kind of floating here randomly
please use gerrit instead 2016/06/30 01:19:27 There was a missing label. Added it back.
+ android:id="@+id/server_card_clear_button"
+ android:layout_height="wrap_content"
+ android:layout_width="wrap_content"
+ android:paddingTop="@dimen/pref_autofill_field_top_padding"
gone 2016/06/29 20:09:41 Don't customize the padding of the button. Are yo
please use gerrit instead 2016/06/30 01:19:27 Done.
+ android:paddingBottom="@dimen/pref_autofill_field_top_padding"
+ android:minHeight="40dp"
gone 2016/06/29 20:09:41 Don't set the minHeight; should be handled by the
please use gerrit instead 2016/06/30 01:19:27 Done.
+ android:textColor="#fff"
+ android:text="@string/autofill_clear_local_copy_button"
+ app:buttonColor="@color/pref_accent_color" />
+
+ <!-- The section that's shown only for local cards. -->
<org.chromium.chrome.browser.widget.FloatLabelLayout
android:id="@+id/credit_card_name_label"
android:layout_width="match_parent"
@@ -38,6 +92,7 @@
</org.chromium.chrome.browser.widget.FloatLabelLayout>
<TextView
+ android:id="@+id/credit_card_expiration_label"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:focusable="true"
@@ -48,6 +103,7 @@
android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" />
<LinearLayout
+ android:id="@+id/credit_card_expiration_container"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:orientation="horizontal"
@@ -82,6 +138,7 @@
</LinearLayout>
</LinearLayout>
+ <!-- The section that's shown for both local and server cards. -->
<TextView
android:layout_width="match_parent"
android:layout_height="wrap_content"

Powered by Google App Engine
This is Rietveld 408576698