Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <!-- EditText views in FloatLabelLayout require both hint and contentDescription to be set | 6 <!-- EditText views in FloatLabelLayout require both hint and contentDescription to be set |
| 7 to work correctly for accessibility because FloatLabelLayout sometimes clea r hint. --> | 7 to work correctly for accessibility because FloatLabelLayout sometimes clea r hint. --> |
| 8 <!--suppress ContentDescription --> | 8 <!--suppress ContentDescription --> |
| 9 <merge | 9 <merge |
| 10 xmlns:android="http://schemas.android.com/apk/res/android" | 10 xmlns:android="http://schemas.android.com/apk/res/android" |
| 11 xmlns:app="http://schemas.android.com/apk/res-auto" > | 11 xmlns:app="http://schemas.android.com/apk/res-auto" > |
| 12 | 12 |
| 13 <!-- The section that's shown only for server cards. --> | |
|
gone
2016/06/29 20:09:41
One big problem with jamming in the controls into
please use gerrit instead
2016/06/30 01:19:27
Layouts are split-up.
| |
| 14 <org.chromium.ui.widget.TextViewWithClickableSpans | |
| 15 android:id="@+id/server_card_label" | |
| 16 android:layout_width="wrap_content" | |
|
gone
2016/06/29 20:09:41
match_parent
please use gerrit instead
2016/06/30 01:19:27
Done.
| |
| 17 android:layout_height="wrap_content" | |
| 18 style="@style/PreferenceTitle" | |
| 19 android:text="Visa 3832" /> | |
| 20 | |
| 21 <org.chromium.ui.widget.TextViewWithClickableSpans | |
| 22 android:id="@+id/server_card_sublabel" | |
| 23 android:layout_width="wrap_content" | |
|
gone
2016/06/29 20:09:42
match_parent
please use gerrit instead
2016/06/30 01:19:27
Done.
| |
| 24 android:layout_height="wrap_content" | |
| 25 style="@style/PreferenceSummary" | |
| 26 android:text="08/2017" /> | |
| 27 | |
| 28 <LinearLayout | |
| 29 android:id="@+id/server_card_edit_link_container" | |
| 30 android:layout_width="match_parent" | |
| 31 android:layout_height="wrap_content" | |
| 32 android:paddingTop="@dimen/pref_autofill_field_top_padding" | |
| 33 android:paddingBottom="@dimen/pref_autofill_field_top_padding" | |
| 34 android:orientation="horizontal" | |
| 35 android:baselineAligned="false" > | |
| 36 | |
| 37 <org.chromium.ui.widget.TextViewWithClickableSpans | |
| 38 android:layout_width="wrap_content" | |
| 39 android:layout_height="wrap_content" | |
| 40 android:paddingEnd="15dp" | |
| 41 android:layout_weight="1" | |
| 42 style="@style/PreferenceTitle" | |
| 43 android:text="@string/autofill_from_google_account_long" /> | |
| 44 | |
| 45 <org.chromium.ui.widget.TextViewWithClickableSpans | |
| 46 android:id="@+id/server_card_edit_link" | |
| 47 android:layout_width="wrap_content" | |
| 48 android:layout_height="wrap_content" | |
| 49 android:textColor="?android:attr/textColorLink" | |
| 50 android:textAllCaps="true" | |
| 51 android:text="@string/autofill_wallet_management_link_text" /> | |
| 52 | |
| 53 </LinearLayout> | |
| 54 | |
| 55 <org.chromium.ui.widget.ButtonCompat | |
|
gone
2016/06/29 20:09:41
This button is just kind of floating here randomly
please use gerrit instead
2016/06/30 01:19:27
There was a missing label. Added it back.
| |
| 56 android:id="@+id/server_card_clear_button" | |
| 57 android:layout_height="wrap_content" | |
| 58 android:layout_width="wrap_content" | |
| 59 android:paddingTop="@dimen/pref_autofill_field_top_padding" | |
|
gone
2016/06/29 20:09:41
Don't customize the padding of the button. Are yo
please use gerrit instead
2016/06/30 01:19:27
Done.
| |
| 60 android:paddingBottom="@dimen/pref_autofill_field_top_padding" | |
| 61 android:minHeight="40dp" | |
|
gone
2016/06/29 20:09:41
Don't set the minHeight; should be handled by the
please use gerrit instead
2016/06/30 01:19:27
Done.
| |
| 62 android:textColor="#fff" | |
| 63 android:text="@string/autofill_clear_local_copy_button" | |
| 64 app:buttonColor="@color/pref_accent_color" /> | |
| 65 | |
| 66 <!-- The section that's shown only for local cards. --> | |
| 13 <org.chromium.chrome.browser.widget.FloatLabelLayout | 67 <org.chromium.chrome.browser.widget.FloatLabelLayout |
| 14 android:id="@+id/credit_card_name_label" | 68 android:id="@+id/credit_card_name_label" |
| 15 android:layout_width="match_parent" | 69 android:layout_width="match_parent" |
| 16 android:layout_height="wrap_content" > | 70 android:layout_height="wrap_content" > |
| 17 <EditText | 71 <EditText |
| 18 android:id="@+id/credit_card_name_edit" | 72 android:id="@+id/credit_card_name_edit" |
| 19 android:layout_width="match_parent" | 73 android:layout_width="match_parent" |
| 20 android:layout_height="wrap_content" | 74 android:layout_height="wrap_content" |
| 21 android:imeOptions="flagNoExtractUi" | 75 android:imeOptions="flagNoExtractUi" |
| 22 android:inputType="textCapWords" | 76 android:inputType="textCapWords" |
| 23 android:hint="@string/autofill_credit_card_editor_name" /> | 77 android:hint="@string/autofill_credit_card_editor_name" /> |
| 24 </org.chromium.chrome.browser.widget.FloatLabelLayout> | 78 </org.chromium.chrome.browser.widget.FloatLabelLayout> |
| 25 | 79 |
| 26 <org.chromium.chrome.browser.widget.FloatLabelLayout | 80 <org.chromium.chrome.browser.widget.FloatLabelLayout |
| 27 android:id="@+id/credit_card_number_label" | 81 android:id="@+id/credit_card_number_label" |
| 28 android:layout_width="match_parent" | 82 android:layout_width="match_parent" |
| 29 android:layout_height="wrap_content" > | 83 android:layout_height="wrap_content" > |
| 30 <EditText | 84 <EditText |
| 31 android:id="@+id/credit_card_number_edit" | 85 android:id="@+id/credit_card_number_edit" |
| 32 android:layout_width="match_parent" | 86 android:layout_width="match_parent" |
| 33 android:layout_height="wrap_content" | 87 android:layout_height="wrap_content" |
| 34 android:imeOptions="flagNoExtractUi" | 88 android:imeOptions="flagNoExtractUi" |
| 35 android:inputType="phone" | 89 android:inputType="phone" |
| 36 android:digits="0123456789- " | 90 android:digits="0123456789- " |
| 37 android:hint="@string/autofill_credit_card_editor_number" /> | 91 android:hint="@string/autofill_credit_card_editor_number" /> |
| 38 </org.chromium.chrome.browser.widget.FloatLabelLayout> | 92 </org.chromium.chrome.browser.widget.FloatLabelLayout> |
| 39 | 93 |
| 40 <TextView | 94 <TextView |
| 95 android:id="@+id/credit_card_expiration_label" | |
| 41 android:layout_width="match_parent" | 96 android:layout_width="match_parent" |
| 42 android:layout_height="wrap_content" | 97 android:layout_height="wrap_content" |
| 43 android:focusable="true" | 98 android:focusable="true" |
| 44 android:paddingTop="@dimen/pref_autofill_field_top_padding" | 99 android:paddingTop="@dimen/pref_autofill_field_top_padding" |
| 45 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" | 100 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" |
| 46 android:text="@string/autofill_credit_card_editor_expiration_date" | 101 android:text="@string/autofill_credit_card_editor_expiration_date" |
| 47 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" | 102 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" |
| 48 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" /> | 103 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" /> |
| 49 | 104 |
| 50 <LinearLayout | 105 <LinearLayout |
| 106 android:id="@+id/credit_card_expiration_container" | |
| 51 android:layout_width="match_parent" | 107 android:layout_width="match_parent" |
| 52 android:layout_height="wrap_content" | 108 android:layout_height="wrap_content" |
| 53 android:orientation="horizontal" | 109 android:orientation="horizontal" |
| 54 android:paddingTop="8dp" | 110 android:paddingTop="8dp" |
| 55 android:baselineAligned="false" | 111 android:baselineAligned="false" |
| 56 android:layout_marginStart="@dimen/pref_autofill_field_horizontal_paddin g" | 112 android:layout_marginStart="@dimen/pref_autofill_field_horizontal_paddin g" |
| 57 android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding" > | 113 android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding" > |
| 58 | 114 |
| 59 <LinearLayout | 115 <LinearLayout |
| 60 android:layout_width="0dp" | 116 android:layout_width="0dp" |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 75 android:layout_weight="1" | 131 android:layout_weight="1" |
| 76 android:orientation="vertical" > | 132 android:orientation="vertical" > |
| 77 <android.support.v7.widget.AppCompatSpinner | 133 <android.support.v7.widget.AppCompatSpinner |
| 78 android:id="@+id/autofill_credit_card_editor_year_spinner" | 134 android:id="@+id/autofill_credit_card_editor_year_spinner" |
| 79 android:layout_width="match_parent" | 135 android:layout_width="match_parent" |
| 80 android:layout_height="wrap_content" /> | 136 android:layout_height="wrap_content" /> |
| 81 <View style="@style/PreferenceSpinnerUnderlineView" /> | 137 <View style="@style/PreferenceSpinnerUnderlineView" /> |
| 82 </LinearLayout> | 138 </LinearLayout> |
| 83 </LinearLayout> | 139 </LinearLayout> |
| 84 | 140 |
| 141 <!-- The section that's shown for both local and server cards. --> | |
| 85 <TextView | 142 <TextView |
| 86 android:layout_width="match_parent" | 143 android:layout_width="match_parent" |
| 87 android:layout_height="wrap_content" | 144 android:layout_height="wrap_content" |
| 88 android:focusable="true" | 145 android:focusable="true" |
| 89 android:paddingTop="@dimen/pref_autofill_field_top_padding" | 146 android:paddingTop="@dimen/pref_autofill_field_top_padding" |
| 90 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" | 147 android:textAppearance="@style/PreferenceFloatLabelTextAppearance" |
| 91 android:text="@string/autofill_credit_card_editor_billing_address" | 148 android:text="@string/autofill_credit_card_editor_billing_address" |
| 92 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" | 149 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" |
| 93 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" /> | 150 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" /> |
| 94 | 151 |
| 95 <android.support.v7.widget.AppCompatSpinner | 152 <android.support.v7.widget.AppCompatSpinner |
| 96 android:id="@+id/autofill_credit_card_editor_billing_address_spinner" | 153 android:id="@+id/autofill_credit_card_editor_billing_address_spinner" |
| 97 android:layout_width="match_parent" | 154 android:layout_width="match_parent" |
| 98 android:layout_height="wrap_content" | 155 android:layout_height="wrap_content" |
| 99 android:paddingTop="@dimen/pref_autofill_field_top_padding" | 156 android:paddingTop="@dimen/pref_autofill_field_top_padding" |
| 100 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" | 157 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" |
| 101 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" | 158 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" |
| 102 android:textDirection="locale" /> | 159 android:textDirection="locale" /> |
| 103 <View style="@style/PreferenceSpinnerUnderlineView" | 160 <View style="@style/PreferenceSpinnerUnderlineView" |
| 104 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" | 161 android:paddingStart="@dimen/pref_autofill_field_horizontal_padding" |
| 105 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" /> | 162 android:paddingEnd="@dimen/pref_autofill_field_horizontal_padding" /> |
| 106 | 163 |
| 107 </merge> | 164 </merge> |
| OLD | NEW |