Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5641)

Unified Diff: chrome/android/java/res/layout/autofill_server_card_editor.xml

Issue 2109643003: Add billing address to masked server credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/autofill_server_card_editor.xml
diff --git a/chrome/android/java/res/layout/autofill_server_card_editor.xml b/chrome/android/java/res/layout/autofill_server_card_editor.xml
new file mode 100644
index 0000000000000000000000000000000000000000..67b3f120fce1bc3f9dd051d9c06c2ef14702c1eb
--- /dev/null
+++ b/chrome/android/java/res/layout/autofill_server_card_editor.xml
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2016 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+
+<merge xmlns:android="http://schemas.android.com/apk/res/android">
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/title"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ style="@style/PreferenceTitle"/>
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/summary"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ style="@style/PreferenceSummary"
+ android:layout_marginBottom="@dimen/pref_autofill_field_top_padding"/>
+
+ <include layout="@layout/autofill_billing_address_dropdown"/>
+
+ <RelativeLayout
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:layout_marginTop="@dimen/pref_autofill_field_top_padding">
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/edit_server_card"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_alignParentEnd="true"
gone 2016/06/30 17:26:37 should add an android:layout_alignParentTop="true"
+ android:paddingStart="@dimen/pref_autofill_touch_target_padding"
+ android:paddingTop="@dimen/pref_autofill_touch_target_padding"
+ android:paddingBottom="@dimen/pref_autofill_touch_target_padding"
+ android:textColor="?android:attr/textColorLink"
+ android:textAllCaps="true"
+ android:text="@string/autofill_wallet_management_link_text"/>
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
+ android:id="@+id/server_card_label"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_alignParentStart="true"
+ android:layout_toStartOf="@id/edit_server_card"
+ android:paddingTop="@dimen/pref_autofill_touch_target_padding"
+ android:paddingBottom="@dimen/pref_autofill_touch_target_padding"
+ style="@style/PreferenceTitle"
+ android:text="@string/autofill_from_google_account_long"/>
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
gone 2016/06/30 17:26:37 why are you using TextViewWithClickableSpans? you
please use gerrit instead 2016/06/30 18:36:27 Done.
+ android:id="@+id/clear_local_copy"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_alignParentEnd="true"
+ android:layout_below="@id/server_card_label"
+ android:paddingStart="@dimen/pref_autofill_touch_target_padding"
+ android:paddingTop="@dimen/pref_autofill_touch_target_padding"
+ android:paddingBottom="@dimen/pref_autofill_touch_target_padding"
+ android:textColor="?android:attr/textColorLink"
+ android:textAllCaps="true"
+ android:text="@string/autofill_clear_local_copy_button"/>
+
+ <org.chromium.ui.widget.TextViewWithClickableSpans
gone 2016/06/30 17:26:37 ditto.
please use gerrit instead 2016/06/30 18:36:27 Done.
+ android:id="@+id/local_copy_label"
+ android:layout_width="wrap_content"
+ android:layout_height="wrap_content"
+ android:layout_alignParentStart="true"
+ android:layout_below="@id/server_card_label"
+ android:layout_toStartOf="@id/clear_local_copy"
+ android:paddingTop="@dimen/pref_autofill_touch_target_padding"
+ android:paddingBottom="@dimen/pref_autofill_touch_target_padding"
+ style="@style/PreferenceTitle"
+ android:text="@string/autofill_describe_local_copy"/>
+ </RelativeLayout>
+</merge>

Powered by Google App Engine
This is Rietveld 408576698