chrome/android/java/res/layout/autofill_server_card_editor.xml - Issue 2109643003: Add billing address to masked server credit cards.

Side by Side Diff: chrome/android/java/res/layout/autofill_server_card_editor.xml

Issue 2109643003: Add billing address to masked server credit cards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/autofill_local_card_editor.xml ('K') | « chrome/android/java/res/layout/autofill_server_card_clear_copy_button.xml ('k') | chrome/android/java/res/values/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardEditor.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <merge xmlns:android="http://schemas.android.com/apk/res/android">

	7 <org.chromium.ui.widget.TextViewWithClickableSpans

	8 android:id="@+id/title"

	9 android:layout_width="match_parent"

	10 android:layout_height="wrap_content"

	11 style="@style/PreferenceTitle"/>

	12

	13 <org.chromium.ui.widget.TextViewWithClickableSpans

	14 android:id="@+id/summary"

	15 android:layout_width="match_parent"

	16 android:layout_height="wrap_content"

	17 style="@style/PreferenceSummary"

	18 android:layout_marginBottom="@dimen/pref_autofill_field_top_padding"/>

	19

	20 <include layout="@layout/autofill_billing_address_dropdown"/>

	21

	22 <RelativeLayout

	23 android:layout_width="match_parent"

	24 android:layout_height="wrap_content"

	25 android:layout_marginTop="@dimen/pref_autofill_field_top_padding">

	26

	27 <org.chromium.ui.widget.TextViewWithClickableSpans

	28 android:id="@+id/edit_server_card"

	29 android:layout_width="wrap_content"

	30 android:layout_height="wrap_content"

	31 android:layout_alignParentEnd="true"
	gone 2016/06/30 17:26:37 should add an android:layout_alignParentTop="true" should add an android:layout_alignParentTop="true" here too for clarity
	32 android:paddingStart="@dimen/pref_autofill_touch_target_padding"

	33 android:paddingTop="@dimen/pref_autofill_touch_target_padding"

	34 android:paddingBottom="@dimen/pref_autofill_touch_target_padding"

	35 android:textColor="?android:attr/textColorLink"

	36 android:textAllCaps="true"

	37 android:text="@string/autofill_wallet_management_link_text"/>

	38

	39 <org.chromium.ui.widget.TextViewWithClickableSpans

	40 android:id="@+id/server_card_label"

	41 android:layout_width="wrap_content"

	42 android:layout_height="wrap_content"

	43 android:layout_alignParentStart="true"

	44 android:layout_toStartOf="@id/edit_server_card"

	45 android:paddingTop="@dimen/pref_autofill_touch_target_padding"

	46 android:paddingBottom="@dimen/pref_autofill_touch_target_padding"

	47 style="@style/PreferenceTitle"

	48 android:text="@string/autofill_from_google_account_long"/>

	49

	50 <org.chromium.ui.widget.TextViewWithClickableSpans
	gone 2016/06/30 17:26:37 why are you using TextViewWithClickableSpans? you why are you using TextViewWithClickableSpans? you're not setting Spans anywhere, afaict. do plain TextViews work? please use gerrit instead 2016/06/30 18:36:27 Done. Show quoted text On 2016/06/30 17:26:37, dfalcantara wrote: > why are you using TextViewWithClickableSpans? you're not setting Spans > anywhere, afaict. do plain TextViews work? Done.
	51 android:id="@+id/clear_local_copy"

	52 android:layout_width="wrap_content"

	53 android:layout_height="wrap_content"

	54 android:layout_alignParentEnd="true"

	55 android:layout_below="@id/server_card_label"

	56 android:paddingStart="@dimen/pref_autofill_touch_target_padding"

	57 android:paddingTop="@dimen/pref_autofill_touch_target_padding"

	58 android:paddingBottom="@dimen/pref_autofill_touch_target_padding"

	59 android:textColor="?android:attr/textColorLink"

	60 android:textAllCaps="true"

	61 android:text="@string/autofill_clear_local_copy_button"/>

	62

	63 <org.chromium.ui.widget.TextViewWithClickableSpans
	gone 2016/06/30 17:26:37 ditto. ditto. please use gerrit instead 2016/06/30 18:36:27 Done. Show quoted text On 2016/06/30 17:26:37, dfalcantara wrote: > ditto. Done.
	64 android:id="@+id/local_copy_label"

	65 android:layout_width="wrap_content"

	66 android:layout_height="wrap_content"

	67 android:layout_alignParentStart="true"

	68 android:layout_below="@id/server_card_label"

	69 android:layout_toStartOf="@id/clear_local_copy"

	70 android:paddingTop="@dimen/pref_autofill_touch_target_padding"

	71 android:paddingBottom="@dimen/pref_autofill_touch_target_padding"

	72 style="@style/PreferenceTitle"

	73 android:text="@string/autofill_describe_local_copy"/>

	74 </RelativeLayout>

	75 </merge>

OLD	NEW