Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2109613003: Revert of Make lines a special case in GrShape (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make lines a special case in GrShape (patchset #5 id:120001 of https://codereview.chromium.org/2108523002/ ) Reason for revert: Assertion failures Original issue's description: > Make lines a special case in GrShape > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2108523002 > > Committed: https://skia.googlesource.com/skia/+/c62318c748a1907649bd75382c4f4fd10533f2b3 TBR=robertphillips@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/635df95a9a25c66959f76b4bbb594b75333ded21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -245 lines) Patch
M src/gpu/GrShape.h View 10 chunks +8 lines, -40 lines 0 comments Download
M src/gpu/GrShape.cpp View 10 chunks +21 lines, -70 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/batches/GrDashLinePathRenderer.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/GrShapeTest.cpp View 9 chunks +14 lines, -128 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bsalomon
Created Revert of Make lines a special case in GrShape
4 years, 5 months ago (2016-06-28 18:18:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109613003/1
4 years, 5 months ago (2016-06-28 18:18:38 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 18:18:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/635df95a9a25c66959f76b4bbb594b75333ded21

Powered by Google App Engine
This is Rietveld 408576698