Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2109603003:
gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. (Closed)
Descriptiongpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability.
Large L shape is as follows;
_ _ | | _ _
X| X| |X |X
| ¯¯¯¯ ¯¯¯¯ |
We don't want to blur the corner of a rectangle.
BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/87e9d26652d2f34e76f5dfa0ea0f2d8c78f5b268
Cr-Commit-Position: refs/heads/master@{#402796}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove redundant "if (blurCoeff == 0.0)" #Messages
Total messages: 18 (9 generated)
Description was changed from ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" ========== to ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + adrian.belgun@intel.com, piman@chromium.org
piman@ could you review? It's the 4th CL of https://bugs.chromium.org/p/chromium/issues/detail?id=535198#c16
lgtm
lgtm with nits https://codereview.chromium.org/2109603003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2109603003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1579: if (blurCoeff == 0.0) { Nit: this no longer needed. See line 1533.
thx for reviewing! https://codereview.chromium.org/2109603003/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc (right): https://codereview.chromium.org/2109603003/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc:1579: if (blurCoeff == 0.0) { On 2016/06/29 10:42:27, adrian.belgun wrote: > Nit: this no longer needed. See line 1533. That's right. Done, with new assertion comment.
The CQ bit was checked by dongseong.hwang@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from adrian.belgun@intel.com, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2109603003/#ps20001 (title: "remove redundant "if (blurCoeff == 0.0)"")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_optional_gpu_tests_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
Description was changed from ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== gpu, cmaa: Don't blend large L shape because it would be the intended shape with high probability. Large L shape is as follows; _ _ | | _ _ X| X| |X |X | ¯¯¯¯ ¯¯¯¯ | We don't want to blur the corner of a rectangle. BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/87e9d26652d2f34e76f5dfa0ea0f2d8c78f5b268 Cr-Commit-Position: refs/heads/master@{#402796} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/87e9d26652d2f34e76f5dfa0ea0f2d8c78f5b268 Cr-Commit-Position: refs/heads/master@{#402796} |
