Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2109583003: Blacklist fontscalerdistortable on Win8. (Closed)

Created:
4 years, 5 months ago by dogben
Modified:
4 years, 5 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -1 line) Patch
M tools/dm_flags.json View 1 1 chunk +205 lines, -0 lines 0 comments Download
M tools/dm_flags.py View 1 2 chunks +7 lines, -1 line 1 comment Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109583003/1
4 years, 5 months ago (2016-06-28 15:23:42 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/9327) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
4 years, 5 months ago (2016-06-28 15:25:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109583003/20001
4 years, 5 months ago (2016-06-28 18:21:56 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 18:41:07 UTC) #9
dogben
4 years, 5 months ago (2016-06-28 18:51:47 UTC) #11
bungeman-skia
https://codereview.chromium.org/2109583003/diff/20001/tools/dm_flags.py File tools/dm_flags.py (right): https://codereview.chromium.org/2109583003/diff/20001/tools/dm_flags.py#newcode174 tools/dm_flags.py:174: blacklist.extend('_ gm _ fontscalerdistortable'.split(' ')) This bit lgtm.
4 years, 5 months ago (2016-07-05 17:10:10 UTC) #12
dogben
+mtklein to review test.
4 years, 5 months ago (2016-07-06 13:24:04 UTC) #14
mtklein
lgtm!
4 years, 5 months ago (2016-07-06 13:40:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109583003/20001
4 years, 5 months ago (2016-07-06 13:40:50 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 13:55:08 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c3ea34b1ae0aa682c2409a7a0b08c257952f6ab8

Powered by Google App Engine
This is Rietveld 408576698