Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: tools/dm_flags.py

Issue 2109583003: Blacklist fontscalerdistortable on Win8. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dm_flags.py
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 9672849ee344fc28ca0dbce6a1404595890e3fd0..4a4175c1381b1857cc80442d43f33fff925bfdf7 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -167,7 +167,12 @@ def get_args(bot):
# is fairly slow and not platform-specific. So we just disable it on all of
# Android and iOS. skia:5438
blacklist.extend('_ test _ GrShape'.split(' '))
-
+
+ if 'Win8' in bot:
+ # bungeman: "Doesn't work on Windows anyway, produces unstable GMs with
+ # 'Unexpected error' from DirectWrite"
+ blacklist.extend('_ gm _ fontscalerdistortable'.split(' '))
bungeman-skia 2016/07/05 17:10:10 This bit lgtm.
+
# skia:4095
for test in ['bleed_image',
'c_gms',
@@ -290,6 +295,7 @@ def self_test():
'Test-Win-MSVC-GCE-CPU-AVX2-x86_64-Debug',
'Test-Win10-MSVC-ShuttleA-GPU-GTX660-x86_64-Debug-Vulkan',
'Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Debug-ANGLE',
+ 'Test-Win8-MSVC-GCE-CPU-AVX2-x86_64-Debug',
]
cov = coverage.coverage()
« no previous file with comments | « tools/dm_flags.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698