Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2109573002: Revert of Refactor contact editor controller into its own class. (Closed)

Created:
4 years, 5 months ago by dgn
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor contact editor controller into its own class. (patchset #3 id:40001 of https://codereview.chromium.org/2092083003/ ) Reason for revert: Hits assert on pre-L devices: java.lang.AssertionError at org.chromium.chrome.browser.payments.ui.PaymentOption.updateLabels(PaymentOption.java:67) at org.chromium.chrome.browser.payments.AutofillContact.setPhoneEmail(AutofillContact.java:76) at org.chromium.chrome.browser.payments.AutofillContact.<init>(AutofillContact.java:37) at org.chromium.chrome.browser.payments.ContactEditor.editContact(ContactEditor.java:108) at org.chromium.chrome.browser.payments.PaymentRequestImpl.editContact(PaymentRequestImpl.java:625) at org.chromium.chrome.browser.payments.PaymentRequestImpl.onSectionAddOption(PaymentRequestImpl.java:617) at org.chromium.chrome.browser.payments.ui.PaymentRequestUI.onAddPaymentOption(PaymentRequestUI.java:579) at org.chromium.chrome.browser.payments.ui.PaymentRequestSection$OptionSection.onClick(PaymentRequestSection.java:756) at android.view.View.performClick(View.java:4438) Original issue's description: > Refactor contact editor controller into its own class. > > BUG=603635 > > Committed: https://crrev.com/ed717079ed994eabfa0373635138cc23ea39622f > Cr-Commit-Position: refs/heads/master@{#402352} TBR=dfalcantara@chromium.org,rouslan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=603635 Committed: https://crrev.com/2a8e5adc7f8917f2bbc949358841f06040370594 Cr-Commit-Position: refs/heads/master@{#402433}

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
dgn
Created Revert of Refactor contact editor controller into its own class.
4 years, 5 months ago (2016-06-28 09:28:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109573002/1
4 years, 5 months ago (2016-06-28 09:28:29 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 09:29:11 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 09:31:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a8e5adc7f8917f2bbc949358841f06040370594
Cr-Commit-Position: refs/heads/master@{#402433}

Powered by Google App Engine
This is Rietveld 408576698