Refactor contact editor controller into its own class.

Refactor contact editor controller into its own class.

BUG=603635
Committed: https://crrev.com/ed717079ed994eabfa0373635138cc23ea39622f
Cr-Commit-Position: refs/heads/master@{#402352}

[please use gerrit instead, 2016-06-24 22:03:15]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-06-24 22:03:15]

dfalcantara@, ptal.

There's no base class that we've discussed, because there's only one editor
controller class at the moment. The next patch will be the address editor. That
one will put the common pieces of code into the base class.

[gone, 2016-06-27 21:20:52]

lgtm

https://codereview.chromium.org/2092083003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
(right):

https://codereview.chromium.org/2092083003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java:31:
private final List<CharSequence> mAllPhoneNumbers;
Weird to call this mAllPhoneNumbers/mAllEmailAddresses, but add new ones
conditionally.  Maybe mPhoneNumbers and mEmailAddresses?

[please use gerrit instead, 2016-06-27 22:26:28]

Removed "All" from the names of lists that did not really contain all data.

Made the editor UI match the payments UI size even on large screens.

Sending to cq now.

https://codereview.chromium.org/2092083003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java
(right):

https://codereview.chromium.org/2092083003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ContactEditor.java:31:
private final List<CharSequence> mAllPhoneNumbers;
On 2016/06/27 21:20:52, dfalcantara wrote:
> Weird to call this mAllPhoneNumbers/mAllEmailAddresses, but add new ones
> conditionally.  Maybe mPhoneNumbers and mEmailAddresses?

Renamed.

[please use gerrit instead, 2016-06-27 22:26:37]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-06-27 22:26:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2092083003/#ps40001
(title: "Match payments UI size even on large screens.")

[commit-bot: I haz the power, 2016-06-27 22:27:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 23:57:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 23:57:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[please use gerrit instead, 2016-06-28 00:23:17]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-06-28 00:24:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 00:59:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-28 01:00:42]

Description was changed from

==========
Refactor contact editor controller into its own class.

BUG=603635
==========

to

==========
Refactor contact editor controller into its own class.

BUG=603635

Committed: https://crrev.com/ed717079ed994eabfa0373635138cc23ea39622f
Cr-Commit-Position: refs/heads/master@{#402352}
==========

[commit-bot: I haz the power, 2016-06-28 01:00:43]

Patchset 3 (id:??) landed as
https://crrev.com/ed717079ed994eabfa0373635138cc23ea39622f
Cr-Commit-Position: refs/heads/master@{#402352}

[dgn, 2016-06-28 09:28:18]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2109573002/ by dgn@chromium.org.

The reason for reverting is: Hits assert on pre-L devices:

java.lang.AssertionError
  at
org.chromium.chrome.browser.payments.ui.PaymentOption.updateLabels(PaymentOption.java:67)
  at
org.chromium.chrome.browser.payments.AutofillContact.setPhoneEmail(AutofillContact.java:76)
  at
org.chromium.chrome.browser.payments.AutofillContact.<init>(AutofillContact.java:37)
  at
org.chromium.chrome.browser.payments.ContactEditor.editContact(ContactEditor.java:108)
  at
org.chromium.chrome.browser.payments.PaymentRequestImpl.editContact(PaymentRequestImpl.java:625)
  at
org.chromium.chrome.browser.payments.PaymentRequestImpl.onSectionAddOption(PaymentRequestImpl.java:617)
  at
org.chromium.chrome.browser.payments.ui.PaymentRequestUI.onAddPaymentOption(PaymentRequestUI.java:579)
  at
org.chromium.chrome.browser.payments.ui.PaymentRequestSection$OptionSection.onClick(PaymentRequestSection.java:756)
  at android.view.View.performClick(View.java:4438).

[dgn, 2016-06-28 09:29:31]

On 2016/06/28 09:28:18, dgn wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2109573002/ by mailto:dgn@chromium.org.
> 
> The reason for reverting is: Hits assert on pre-L devices:
> 
> java.lang.AssertionError
>   at
>
org.chromium.chrome.browser.payments.ui.PaymentOption.updateLabels(PaymentOption.java:67)
>   at
>
org.chromium.chrome.browser.payments.AutofillContact.setPhoneEmail(AutofillContact.java:76)
>   at
>
org.chromium.chrome.browser.payments.AutofillContact.<init>(AutofillContact.java:37)
>   at
>
org.chromium.chrome.browser.payments.ContactEditor.editContact(ContactEditor.java:108)
>   at
>
org.chromium.chrome.browser.payments.PaymentRequestImpl.editContact(PaymentRequestImpl.java:625)
>   at
>
org.chromium.chrome.browser.payments.PaymentRequestImpl.onSectionAddOption(PaymentRequestImpl.java:617)
>   at
>
org.chromium.chrome.browser.payments.ui.PaymentRequestUI.onAddPaymentOption(PaymentRequestUI.java:579)
>   at
>
org.chromium.chrome.browser.payments.ui.PaymentRequestSection$OptionSection.onClick(PaymentRequestSection.java:756)
>   at android.view.View.performClick(View.java:4438).

(in tests, e.g. PaymentRequestPhoneTest#testAddPhoneAndPay)