Make SpellChecker::didBeginEdit() not to crash with IFRAME parameter

Make SpellChecker::didBeginEdit() not to crash with elements editing ignore content

This patch makes |SpellChecker::didBeginEdit()| not to pass an element
which returns true for |editingIgnoresContent(element)|, since
|selectionFromContentsOfNode(element)| doesn't accept such elements, to avoid
crash with such elements.

Since test runner sets false for |unifiedTextCheckerEnabled()|, we have not
been aware this. Following patch will make |unifiedTextCheckerEnabled()|
to return true always.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes

Committed: https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b
Cr-Commit-Position: refs/heads/master@{#402714}

[yosin_UTC9, 2016-06-28 08:28:25]

Description was changed from

==========
2016-06-28T16:59:23

BUG=
==========

to

==========
Make SpellChecker::didBeginEdit() not to crash with non-content editable element

This patch makes |SpellChecker::didBeginEdit()| not to crash with non-content
editable element, e.g. IFRAME, METER, and so on, when
|unifiedTextCheckerEnabled()| is true, to make layout tests to use code path
as non-testing environment for improving test coverage.

This patch is a preparation of making |unifiedTextCheckerEnabled()| to
return true in testing environment, e.g. layout test.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes
==========

[yosin_UTC9, 2016-06-28 09:26:39]

yosin@chromium.org changed reviewers:
+ yoichio@chromium.org

[yosin_UTC9, 2016-06-28 09:26:39]

PTAL

[yoichio, 2016-06-29 01:35:57]

https://codereview.chromium.org/2109543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2109543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:143: if
(EditingStrategy::editingIgnoresContent(element))
Please add description why crash happens and this line solves that issue.

[yosin_UTC9, 2016-06-29 02:02:31]

Description was changed from

==========
Make SpellChecker::didBeginEdit() not to crash with non-content editable element

This patch makes |SpellChecker::didBeginEdit()| not to crash with non-content
editable element, e.g. IFRAME, METER, and so on, when
|unifiedTextCheckerEnabled()| is true, to make layout tests to use code path
as non-testing environment for improving test coverage.

This patch is a preparation of making |unifiedTextCheckerEnabled()| to
return true in testing environment, e.g. layout test.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes
==========

to

==========
Make SpellChecker::didBeginEdit() not to crash with elements editing ignore
content

This patch makes |SpellChecker::didBeginEdit()| not to pass an element
which returns true for |editingIgnoresContent(element)|, since
|selectionFromContentsOfNode(element)| doesn't accept such elements, to avoid
crash with such elements.

Since test runner sets false for |unifiedTextCheckerEnabled()|, we have not
been aware this. Following patch will make |unifiedTextCheckerEnabled()|
to return true always.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes
==========

[yosin_UTC9, 2016-06-29 02:03:05]

PTAL

I updated a description.

https://codereview.chromium.org/2109543002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2109543002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:143: if
(EditingStrategy::editingIgnoresContent(element))
On 2016/06/29 at 01:35:57, yoichio wrote:
> Please add description why crash happens and this line solves that issue.

Done.

[yoichio, 2016-06-29 04:14:42]

lgtm

[yosin_UTC9, 2016-06-29 04:21:14]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-06-29 04:21:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 04:25:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 04:28:35]

Description was changed from

==========
Make SpellChecker::didBeginEdit() not to crash with elements editing ignore
content

This patch makes |SpellChecker::didBeginEdit()| not to pass an element
which returns true for |editingIgnoresContent(element)|, since
|selectionFromContentsOfNode(element)| doesn't accept such elements, to avoid
crash with such elements.

Since test runner sets false for |unifiedTextCheckerEnabled()|, we have not
been aware this. Following patch will make |unifiedTextCheckerEnabled()|
to return true always.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes
==========

to

==========
Make SpellChecker::didBeginEdit() not to crash with elements editing ignore
content

This patch makes |SpellChecker::didBeginEdit()| not to pass an element
which returns true for |editingIgnoresContent(element)|, since
|selectionFromContentsOfNode(element)| doesn't accept such elements, to avoid
crash with such elements.

Since test runner sets false for |unifiedTextCheckerEnabled()|, we have not
been aware this. Following patch will make |unifiedTextCheckerEnabled()|
to return true always.

Following test crashes when |unifiedTextCheckerEnabled()| is true:
 - editing/execCommand/append-node-under-document.html
 - editing/text-iterator/backward-textiterator-first-letter-crash.html

BUG=619452
TEST=n/a; no user visible changes

Committed: https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b
Cr-Commit-Position: refs/heads/master@{#402714}
==========

[commit-bot: I haz the power, 2016-06-29 04:28:38]

Patchset 2 (id:??) landed as
https://crrev.com/be44d0ea538814bb21fd76bf562b4247c10f5f9b
Cr-Commit-Position: refs/heads/master@{#402714}