Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

Issue 2109543002: Make SpellChecker::didBeginEdit() not to crash with IFRAME parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: 2016-06-28T17:34:15 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
diff --git a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
index 5ced5f51e552afcf9632cbe705ffc64ad2f121cd..07c4c9611ec3ad3495929e7c0048a1b8d5ead985 100644
--- a/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
@@ -140,6 +140,8 @@ void SpellChecker::didBeginEditing(Element* element)
}
if (isTextField || !parent->isAlreadySpellChecked()) {
+ if (EditingStrategy::editingIgnoresContent(element))
yoichio 2016/06/29 01:35:57 Please add description why crash happens and this
yosin_UTC9 2016/06/29 02:03:04 Done.
+ return;
// We always recheck textfields because markers are removed from them on blur.
VisibleSelection selection = VisibleSelection::selectionFromContentsOfNode(element);
markMisspellingsAndBadGrammar(selection);
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/text-iterator/backward-textiterator-first-letter-crash.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698