Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: net/url_request/url_request_http_job_unittest.cc

Issue 2109503009: Refactor net tests to use GMock matchers for checking net::Error results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to contents.txt files Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_http_job_unittest.cc
diff --git a/net/url_request/url_request_http_job_unittest.cc b/net/url_request/url_request_http_job_unittest.cc
index 5165382eb3b4c632495d7700dec543e73e65eeff..bb00e4965472d21ec19d238bab7de5af97a95a4a 100644
--- a/net/url_request/url_request_http_job_unittest.cc
+++ b/net/url_request/url_request_http_job_unittest.cc
@@ -25,6 +25,7 @@
#include "net/log/test_net_log_util.h"
#include "net/socket/socket_test_util.h"
#include "net/test/cert_test_util.h"
+#include "net/test/gtest_util.h"
#include "net/test/test_data_directory.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_job_factory_impl.h"
@@ -36,6 +37,9 @@
#include "url/gurl.h"
#include "url/url_constants.h"
+using net::test::IsError;
+using net::test::IsOk;
+
namespace net {
namespace {
@@ -405,7 +409,7 @@ TEST_F(URLRequestHttpJobWithMockSocketsTest, BackoffHeader) {
base::RunLoop().Run();
EXPECT_FALSE(request2->status().is_success());
- EXPECT_EQ(ERR_TEMPORARY_BACKOFF, request2->status().error());
+ EXPECT_THAT(request2->status().error(), IsError(ERR_TEMPORARY_BACKOFF));
EXPECT_EQ(0, delegate2.received_before_network_start_count());
}
@@ -982,7 +986,7 @@ TEST_F(URLRequestHttpJobWebSocketTest, RejectedWithoutCreateHelper) {
req_->Start();
base::RunLoop().RunUntilIdle();
EXPECT_EQ(URLRequestStatus::FAILED, req_->status().status());
- EXPECT_EQ(ERR_DISALLOWED_URL_SCHEME, req_->status().error());
+ EXPECT_THAT(req_->status().error(), IsError(ERR_DISALLOWED_URL_SCHEME));
}
TEST_F(URLRequestHttpJobWebSocketTest, CreateHelperPassedThrough) {
« no previous file with comments | « net/url_request/url_request_ftp_job_unittest.cc ('k') | net/url_request/url_request_job_factory_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698