Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2109483004: [builtins] Drop the special MathRandomRaw. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Drop the special MathRandomRaw. This is the last user of %_DoubleLo and actually unnecessary, since we can just use the normal Math.random() instead. R=yangguo@chromium.org Committed: https://crrev.com/50e19547038bf2510bd750853560e7a20623cdb0 Cr-Commit-Position: refs/heads/master@{#37359}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix off-by-one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M src/js/collection.js View 1 3 chunks +3 lines, -3 lines 0 comments Download
M src/js/math.js View 2 chunks +1 line, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-29 05:50:45 UTC) #1
Yang
LGTM with comment. https://codereview.chromium.org/2109483004/diff/1/src/js/collection.js File src/js/collection.js (right): https://codereview.chromium.org/2109483004/diff/1/src/js/collection.js#newcode116 src/js/collection.js:116: hash = (MathRandom() * 0x3FFFFFFF) | ...
4 years, 5 months ago (2016-06-29 05:53:42 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/2109483004/diff/1/src/js/collection.js File src/js/collection.js (right): https://codereview.chromium.org/2109483004/diff/1/src/js/collection.js#newcode116 src/js/collection.js:116: hash = (MathRandom() * 0x3FFFFFFF) | 0; On 2016/06/29 ...
4 years, 5 months ago (2016-06-29 05:54:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109483004/20001
4 years, 5 months ago (2016-06-29 05:54:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 06:19:36 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 06:21:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/50e19547038bf2510bd750853560e7a20623cdb0
Cr-Commit-Position: refs/heads/master@{#37359}

Powered by Google App Engine
This is Rietveld 408576698