Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2108793003: [turbofan] Drop the obsolete TypeGuard operator. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@MathRandom
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Drop the obsolete TypeGuard operator. The only real use case left for TypeGuard was the renaming inside the LoadElimination, but this case only occurs in dead code (guarded by a previous Check), so it's not relevant, and we can drop the TypeGuard operator completely. R=jarin@chromium.org Committed: https://crrev.com/be32c055f19d68c418148dd75a2fe8b8da9c1f61 Cr-Commit-Position: refs/heads/master@{#37361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -164 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/compiler/escape-analysis.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/compiler/load-elimination.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-29 05:58:50 UTC) #1
Benedikt Meurer
Hey Jaro, Dropping the TypeGuard completely. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-06-29 05:59:34 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-06-29 06:07:06 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 2109483004 Patch 20001). Please resolve the dependency and ...
4 years, 5 months ago (2016-06-29 06:07:33 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108793003/1
4 years, 5 months ago (2016-06-29 06:08:05 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 06:26:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108793003/1
4 years, 5 months ago (2016-06-29 06:32:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 06:34:12 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 06:36:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be32c055f19d68c418148dd75a2fe8b8da9c1f61
Cr-Commit-Position: refs/heads/master@{#37361}

Powered by Google App Engine
This is Rietveld 408576698