Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2109473005: Milo: Pending swarming builds (Closed)

Created:
4 years, 5 months ago by Ryan Tseng
Modified:
4 years, 5 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Pending swarming builds This makes a pending build look less menacing BUG=620457 Committed: https://github.com/luci/luci-go/commit/daf57a8831848f747ee69c1f4c28ffb9ab0e3620

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review and bug fix #

Patch Set 3 : Cleanup, new test data, fix timing display #

Unified diffs Side-by-side diffs Delta from patch set Stats (+542 lines, -441 lines) Patch
M appengine/cmd/milo/Makefile View 1 chunk +6 lines, -0 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html View 1 2 3 chunks +370 lines, -352 lines 0 comments Download
M appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html View 1 2 3 chunks +22 lines, -9 lines 0 comments Download
M appengine/cmd/milo/frontend/static/buildbot/css/default.css View 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/frontend/static/common/js/time.js View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M appengine/cmd/milo/frontend/templates/buildbot/pages/build.html View 1 2 4 chunks +56 lines, -30 lines 0 comments Download
A appengine/cmd/milo/frontend/testdata/build-pending.swarm View 1 1 chunk +1 line, -0 lines 0 comments Download
M appengine/cmd/milo/swarming/build.go View 1 2 3 chunks +45 lines, -34 lines 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-patch-failure.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M appengine/cmd/milo/swarming/expectations/build-pending.json View 1 2 2 chunks +19 lines, -7 lines 0 comments Download
D appengine/cmd/milo/swarming/testdata/build-pending View 1 chunk +0 lines, -1 line 0 comments Download
M appengine/cmd/milo/swarming/testdata/build-pending.swarm View 1 2 1 chunk +17 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109473005/1
4 years, 5 months ago (2016-06-28 19:19:08 UTC) #2
Ryan Tseng
Screenshot: https://screenshot.googleplex.com/V85ZNNe56Xd
4 years, 5 months ago (2016-06-28 19:19:46 UTC) #5
Ryan Tseng
Screenshot: https://screenshot.googleplex.com/V85ZNNe56Xd
4 years, 5 months ago (2016-06-28 19:29:17 UTC) #6
nodir
https://codereview.chromium.org/2109473005/diff/1/appengine/cmd/milo/swarming/build.go File appengine/cmd/milo/swarming/build.go (right): https://codereview.chromium.org/2109473005/diff/1/appengine/cmd/milo/swarming/build.go#newcode300 appengine/cmd/milo/swarming/build.go:300: // If not, we don't necessarily expect the log ...
4 years, 5 months ago (2016-06-28 20:36:49 UTC) #7
Ryan Tseng
Review and bug fix
4 years, 5 months ago (2016-06-28 20:48:06 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109473005/20001
4 years, 5 months ago (2016-06-28 20:48:07 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 20:54:37 UTC) #12
nodir
lgtm please make sure build page won't show NaN as start time
4 years, 5 months ago (2016-06-28 21:14:30 UTC) #13
Ryan Tseng
Cleanup, new test data, fix timing display
4 years, 5 months ago (2016-06-28 21:43:49 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109473005/40001
4 years, 5 months ago (2016-06-28 21:43:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109473005/40001
4 years, 5 months ago (2016-06-28 21:44:36 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 22:30:37 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/daf57a8831848f747ee69c1f4c28ffb9ab0e3620

Powered by Google App Engine
This is Rietveld 408576698