Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html

Issue 2109473005: Milo: Pending swarming builds (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Patch Set: Cleanup, new test data, fix timing display Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html
diff --git a/appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html b/appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html
index 25921da17008c570004432053bc9e36789deec34..c10e8d89337f6e021ccbbc443dcea0d211ccc90b 100644
--- a/appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html
+++ b/appengine/cmd/milo/frontend/expectations/buildbot-swarming.TestableBuild-Basic_successful_build.html
@@ -36,10 +36,7 @@
- <h2>Steps and Logfiles:</h2>
- <ol>
-
- </ol>
+
</div>
@@ -59,15 +56,25 @@
<table class="info" width="100%">
<tr class="alt"><td class="left">Start</td>
<td>
- <span id="started-time">Monday, 02-Jan-06 15:04:05 UTC</span>
+ <span id="started-time">
+
+ Monday, 02-Jan-06 15:04:05 UTC
+
+ </span>
</td></tr>
<tr><td class="left">End</td>
<td>
- <span id="finished-time">Monday, 02-Jan-06 15:04:06 UTC</span>
+ <span id="finished-time">
+
+ Monday, 02-Jan-06 15:04:06 UTC
+
+ </span>
</td></tr>
<tr class="alt"><td class="left">Elapsed</td>
<td id="duration">
- 1 secs
+
+ 1 secs
+
</td></tr>
</table>
@@ -90,8 +97,14 @@
'use strict';
var startedSpan = document.getElementById('started-time');
var finishedSpan = document.getElementById('finished-time');
- startedSpan.textContent = milo.formatDate('2006-01-02T15:04:05.999999999Z');
- finishedSpan.textContent = milo.formatDate('2006-01-02T15:04:06.999999999Z');
+ var started = milo.formatDate('2006-01-02T15:04:05.999999999Z');
+ var finished = milo.formatDate('2006-01-02T15:04:06.999999999Z');
+ if (started) {
+ startedSpan.textContent = started;
+ }
+ if (finished) {
+ finishedSpan.textContent = finished;
+ }
})();
</script>

Powered by Google App Engine
This is Rietveld 408576698