gni/isolate.gni - Issue 2109423002: Revert of [gn] Fix valgrind config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gni/isolate.gni

Issue 2109423002: Revert of [gn] Fix valgrind config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gni/isolate.gni

diff --git a/gni/isolate.gni b/gni/isolate.gni

index c2c025ce0c19f3a020c00ee60db71c1dff007602..e6d166c4603228eba59412cfe309c10d1ab38e40 100644

--- a/gni/isolate.gni

+++ b/gni/isolate.gni

@@ -101,11 +101,6 @@

} else {

use_snapshot = "false"

}

- if (v8_has_valgrind) {

- has_valgrind = "1"

- } else {

- has_valgrind = "0"

- }

# Note, all paths will be rebased in isolate_driver.py to be relative to

# the isolate file.

@@ -137,7 +132,7 @@

"--config-variable",

"gcmole=0",

"--config-variable",

- "has_valgrind=$has_valgrind",

+ "has_valgrind=0",

"--config-variable",

"icu_use_data_file_flag=$icu_use_data_file_flag",

"--config-variable",

« no previous file with comments | « BUILD.gn ('k') | infra/mb/mb_config.pyl » ('j') | no next file with comments »