Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 2109403002: [gn] Fix valgrind config (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix valgrind config BUG=chromium:474921 NOTRY=true NOTREECHECKS=true TBR=vogelheim@chromium.org, jochen@chromium.org Committed: https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291 Cr-Commit-Position: refs/heads/master@{#37418}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M gni/isolate.gni View 2 chunks +6 lines, -1 line 0 comments Download
M infra/mb/mb_config.pyl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Michael Achenbach
TBR. Overlooked this TODO in: https://chromium.googlesource.com/v8/v8/+/3cfc9f209ed0c173319659114859b7e848812fd7 Without this fix, the valgrind binaries are not copied ...
4 years, 5 months ago (2016-06-30 07:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109403002/1
4 years, 5 months ago (2016-06-30 07:36:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109403002/1
4 years, 5 months ago (2016-06-30 07:37:02 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 07:38:27 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e97c990a2b1fd0b5b90832a7f182daa25fee8291 Cr-Commit-Position: refs/heads/master@{#37418}
4 years, 5 months ago (2016-06-30 07:39:25 UTC) #13
Michael Achenbach
4 years, 5 months ago (2016-06-30 07:50:06 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2109423002/ by machenbach@chromium.org.

The reason for reverting is: Breaks....

Powered by Google App Engine
This is Rietveld 408576698