infra/mb/mb_config.pyl - Issue 2109403002: [gn] Fix valgrind config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/mb/mb_config.pyl

Issue 2109403002: [gn] Fix valgrind config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: infra/mb/mb_config.pyl

diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl

index 79d5b480c2037a15d6f160e45cb7a0d89f8ed99a..fa4da999f8ec7d95e4b08a50fae9f63181a8d8f4 100644

--- a/infra/mb/mb_config.pyl

+++ b/infra/mb/mb_config.pyl

@@ -544,8 +544,7 @@

'valgrind': {

- # TODO(machenbach): Add this to gn.

- 'gn_args': 'has_valgrind=true',

+ 'gn_args': 'v8_has_valgrind=true',

'gyp_defines': 'has_valgrind=1',

« no previous file with comments | « gni/isolate.gni ('k') | no next file » | no next file with comments »