Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: infra/mb/mb_config.pyl

Issue 2109403002: [gn] Fix valgrind config (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gni/isolate.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: infra/mb/mb_config.pyl
diff --git a/infra/mb/mb_config.pyl b/infra/mb/mb_config.pyl
index 79d5b480c2037a15d6f160e45cb7a0d89f8ed99a..fa4da999f8ec7d95e4b08a50fae9f63181a8d8f4 100644
--- a/infra/mb/mb_config.pyl
+++ b/infra/mb/mb_config.pyl
@@ -544,8 +544,7 @@
},
'valgrind': {
- # TODO(machenbach): Add this to gn.
- 'gn_args': 'has_valgrind=true',
+ 'gn_args': 'v8_has_valgrind=true',
'gyp_defines': 'has_valgrind=1',
},
« no previous file with comments | « gni/isolate.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698