chromecast/browser/android/BUILD.gn - Issue 2109293003: 🎊 Reland #2 of Have build_config targets depend only on other build_config targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/BUILD.gn

Issue 2109293003: 🎊 Reland #2 of Have build_config targets depend only on other build_config targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change // to * to fix downstream Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromecast/browser/android/BUILD.gn

diff --git a/chromecast/browser/android/BUILD.gn b/chromecast/browser/android/BUILD.gn

index 9ab6299cf5dc4ec9c1cbac967c09cb2d0f9bc230..51f4ed60e97c0022c2f9ee12c2cf1e20f26e8653 100644

--- a/chromecast/browser/android/BUILD.gn

+++ b/chromecast/browser/android/BUILD.gn

@@ -15,10 +15,8 @@ jinja_template("cast_shell_manifest") {

# GYP target: n/a

android_resources("cast_shell_android_resources") {

android_manifest = "$root_gen_dir/cast_shell_manifest/AndroidManifest.xml"

+ android_manifest_dep = ":cast_shell_manifest"

resource_dirs = [ "//chromecast/browser/android/apk/res" ]

- deps = [

- ":cast_shell_manifest",

- ]

}

# GYP target: chromecast.gyp:cast_shell_java

« no previous file with comments | « build/config/android/rules.gni ('k') | content/shell/android/BUILD.gn » ('j') | no next file with comments »