content/shell/android/BUILD.gn - Issue 2109293003: 🎊 Reland #2 of Have build_config targets depend only on other build_config targets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/BUILD.gn

Issue 2109293003: 🎊 Reland #2 of Have build_config targets depend only on other build_config targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: change // to * to fix downstream Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/shell/android/BUILD.gn

diff --git a/content/shell/android/BUILD.gn b/content/shell/android/BUILD.gn

index 96d468ff69f70f1cc796cc30b09737328071d579..b3393463a170dcc6fbb1c56f0df35b79a21c979b 100644

--- a/content/shell/android/BUILD.gn

+++ b/content/shell/android/BUILD.gn

@@ -73,9 +73,9 @@ android_resources("content_shell_apk_resources") {

resource_dirs = [ "shell_apk/res" ]

deps = [

":content_shell_java_resources",

- ":content_shell_manifest",

]

android_manifest = content_shell_manifest

+ android_manifest_dep = ":content_shell_manifest"

}

android_library("content_shell_apk_java") {

@@ -176,9 +176,7 @@ if (current_cpu != "x64") {

testonly = true

resource_dirs = [ "linker_test_apk/res" ]

android_manifest = chromium_linker_test_manifest

- deps = [

- ":chromium_linker_test_manifest",

- ]

+ android_manifest_dep = ":chromium_linker_test_manifest"

}

# GYP: //content/content_tests.gypi:chromium_linker_test_apk

« no previous file with comments | « chromecast/browser/android/BUILD.gn ('k') | no next file » | no next file with comments »