Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109273002: IndexedDB: Created IndexedDBDataLossInfo. (Closed)

Created:
4 years, 5 months ago by cmumford
Modified:
4 years, 5 months ago
Reviewers:
michaeln, jsbell
CC:
chromium-reviews, darin-cc_chromium.org, jsbell+idb_chromium.org, jam, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Created IndexedDBDataLossInfo. Combined the data loss status/message values into a struct. Committed: https://crrev.com/2d8f8c91011d9a2c6ef418645c0c5e35b70ad04f Cr-Commit-Position: refs/heads/master@{#404953}

Patch Set 1 #

Total comments: 2

Patch Set 2 : initializing data loss in IndexedDBBackingStore::Open #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -173 lines) Patch
M content/browser/indexed_db/indexed_db_backing_store.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.cc View 1 6 chunks +13 lines, -18 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store_unittest.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.h View 4 chunks +11 lines, -6 lines 0 comments Download
M content/browser/indexed_db/indexed_db_callbacks.cc View 15 chunks +14 lines, -19 lines 0 comments Download
M content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc View 6 chunks +18 lines, -60 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_impl.cc View 1 6 chunks +18 lines, -25 lines 0 comments Download
M content/browser/indexed_db/indexed_db_factory_unittest.cc View 3 chunks +6 lines, -14 lines 0 comments Download
M content/browser/indexed_db/mock_indexed_db_factory.h View 1 chunk +4 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 2140193002 Patch 1

Messages

Total messages: 25 (11 generated)
cmumford
I was prompted to make this change for IDB's conversion from IPC to Mojo as ...
4 years, 5 months ago (2016-06-29 22:53:48 UTC) #2
jsbell
lgtm
4 years, 5 months ago (2016-07-07 17:22:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109273002/1
4 years, 5 months ago (2016-07-07 17:23:43 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/100077)
4 years, 5 months ago (2016-07-07 18:38:29 UTC) #8
michaeln
lgtm https://codereview.chromium.org/2109273002/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/2109273002/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc#newcode969 content/browser/indexed_db/indexed_db_backing_store.cc:969: DCHECK(!path_base.empty()); maybe DCHECK data_loss_info indicates WebIDBDataLossNone on entry, ...
4 years, 5 months ago (2016-07-08 01:41:26 UTC) #9
cmumford
https://codereview.chromium.org/2109273002/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc File content/browser/indexed_db/indexed_db_backing_store.cc (right): https://codereview.chromium.org/2109273002/diff/1/content/browser/indexed_db/indexed_db_backing_store.cc#newcode969 content/browser/indexed_db/indexed_db_backing_store.cc:969: DCHECK(!path_base.empty()); On 2016/07/08 01:41:26, michaeln wrote: > maybe DCHECK ...
4 years, 5 months ago (2016-07-11 20:28:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109273002/20001
4 years, 5 months ago (2016-07-11 20:29:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/190439)
4 years, 5 months ago (2016-07-12 00:12:58 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109273002/20001
4 years, 5 months ago (2016-07-12 14:16:56 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191296)
4 years, 5 months ago (2016-07-12 18:24:17 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109273002/20001
4 years, 5 months ago (2016-07-12 22:13:25 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:22:23 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:23:24 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:23:55 UTC) #25
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2d8f8c91011d9a2c6ef418645c0c5e35b70ad04f
Cr-Commit-Position: refs/heads/master@{#404953}

Powered by Google App Engine
This is Rietveld 408576698