IndexedDB: Saving data loss status in IndexedDBPendingConnection.

IndexedDB: Saving data loss status in IndexedDBPendingConnection.

Database data loss is a non-standard extension to IDBVersionChangeEvent
(https://www.w3.org/Bugs/Public/show_bug.cgi?id=22370). This state only
needs to be persisted as part of the database open. So moving this value
from IndexedDBCallbacks (used for any IDB call) to
IndexedDBPendingConnection (only used during database open).

BUG=627484
Committed: https://crrev.com/fbd8d172f1497641c4d6c9c56025d18e7d50eb00
Cr-Commit-Position: refs/heads/master@{#407208}

[cmumford, 2016-07-12 15:31:52]

jsbell@

I made this change because the current CL to Mojo'ify IDB deletes the
IndexedDBCallbacks class where IndexedDBDataLossInfo currently lives. It doesn't
replace it with a single class, and instead uses closures for each callback - so
IndexedDBDataLossInfo needed to move.

However, this meant that IndexedDBPendingConnection needs to be shared with only
one instance used for each pending connection - hence the switch to a WeakPtr to
a class instead of a copy-able struct.

[cmumford, 2016-07-12 16:03:14]

cmumford@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2016-07-12 23:23:00]

I'm going to need to chew on this for a while longer. It collides rather
directly with a CL I'm working on (not uploaded yet) that completely redoes the
open/delete request queue in IndexedDBDatabase to align our implementation with
other browsers. So I'm mentally juggling the three impls (current code, your CL,
my CL).

One thing that stood out is this pattern:

base::WeakPtr<IndexedDBPendingConnection> c =
IndexedDBPendingConnection::Create(...);
factory()->Open(c, std::move(c), ...);

It's unclear where ownership of the connection is through this.

Perhaps we should discuss offline and compare CLs.

[cmumford, 2016-07-22 16:09:00]

The CQ bit was checked by cmumford@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 16:09:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cmumford, 2016-07-22 16:23:44]

Simpler version w/o leaks.

[jsbell, 2016-07-22 17:00:54]

lgtm

[cmumford, 2016-07-22 17:36:12]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2016-07-22 17:36:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 18:25:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-22 18:27:05]

Description was changed from

==========
IndexedDB: Saving data loss status in IndexedDBPendingConnection.

Database data loss is a non-standard extension to IDBVersionChangeEvent
(https://www.w3.org/Bugs/Public/show_bug.cgi?id=22370). This state only
needs to be persisted as part of the database open. So moving this value
from IndexedDBCallbacks (used for any IDB call) to
IndexedDBPendingConnection (only used during database open).

BUG=627484
==========

to

==========
IndexedDB: Saving data loss status in IndexedDBPendingConnection.

Database data loss is a non-standard extension to IDBVersionChangeEvent
(https://www.w3.org/Bugs/Public/show_bug.cgi?id=22370). This state only
needs to be persisted as part of the database open. So moving this value
from IndexedDBCallbacks (used for any IDB call) to
IndexedDBPendingConnection (only used during database open).

BUG=627484

Committed: https://crrev.com/fbd8d172f1497641c4d6c9c56025d18e7d50eb00
Cr-Commit-Position: refs/heads/master@{#407208}
==========

[commit-bot: I haz the power, 2016-07-22 18:27:06]

Patchset 3 (id:??) landed as
https://crrev.com/fbd8d172f1497641c4d6c9c56025d18e7d50eb00
Cr-Commit-Position: refs/heads/master@{#407208}