Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2109263002: Revert of Update containing block's positioned descendants list when an object becomes ... (Closed)

Created:
4 years, 5 months ago by Charlie Reis
Modified:
4 years, 5 months ago
Reviewers:
Xianzhu
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Revert of Update containing block's positioned descendants list when an object becomes out-of-flow-positioned (patchset #1 id:1 of https://codereview.chromium.org/2111643002/ ) Reason for revert: Caused a compile error in the M52 build. See https://crbug.com/624571 for details. Original issue's description: > Update containing block's positioned descendants list when an object becomes out-of-flow-positioned > > This is required when there are descendants needing overflow recalc. > Otherwise during overflow recalc because the containing block's > positioned descendant list didn't contain the new out-of-flow-positioned > object we would not reach the descendants needing overflow recalc. > > BUG=623867 > TEST=fast/overflow/add-visual-overflow-and-change-container-position.html > > Review-Url: https://codereview.chromium.org/2103843003 > Cr-Commit-Position: refs/heads/master@{#402550} > Committed: https://chromium.googlesource.com/chromium/src/+/ea9c8c0ffffe09bb297ed9c5c619f411e06f7250 TBR=wangxianzhu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
D third_party/WebKit/LayoutTests/fast/overflow/add-visual-overflow-and-change-container-position.html View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/overflow/add-visual-overflow-and-change-container-position-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Charlie Reis
Created Revert of Update containing block's positioned descendants list when an object becomes out-of-flow-positioned
4 years, 5 months ago (2016-06-29 22:29:51 UTC) #2
Xianzhu
4 years, 5 months ago (2016-06-29 22:34:04 UTC) #5
On 2016/06/29 22:29:51, Charlie Reis wrote:
> Created Revert of Update containing block's positioned descendants list when
an
> object becomes out-of-flow-positioned

Thanks for creating this. Stopped CQ of this CL and I'll fix the error asap.

Powered by Google App Engine
This is Rietveld 408576698