[MD Settings] Add Edit/Create Address Dialog to MD Settings.

[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70
Cr-Commit-Position: refs/heads/master@{#405303}

[hcarmona, 2016-06-29 21:31:46]

Description was changed from

==========
Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
==========

to

==========
Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-06 20:33:30]

Description was changed from

==========
Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-06 22:54:58]

Patchset #2 (id:20001) has been deleted

[hcarmona, 2016-07-06 22:55:07]

Patchset #2 (id:40001) has been deleted

[hcarmona, 2016-07-07 20:25:46]

hcarmona@chromium.org changed reviewers:
+ michaelpg@chromium.org

[hcarmona, 2016-07-07 20:25:47]

I've broken down the test into smaller pieces.
This was timing out in msan tests. Hoping that breaking it up will
remove the timeouts, if not then at the very least it will narrow down
the failure.

WDYT?

[michaelpg, 2016-07-08 00:55:32]

lgtm

https://codereview.chromium.org/2109233002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
(right):

https://codereview.chromium.org/2109233002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:110:
/** @override */
do you get any other a11y errors when running these tests?

i've found "runAccessibilityChecks: false" on the prototype, like in
SettingsPageBrowserTest, sometimes speeds up the test a lot.

https://codereview.chromium.org/2109233002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:189:
TEST_F('SettingsAutofillSectionBrowserTest', 'creditCardTests', function() {
i think the convention is for the test in TEST_F to be CapitalCamelCase:
CreditCardTests

[hcarmona, 2016-07-11 21:50:54]

Addressed feedback, committing if no objections.

https://codereview.chromium.org/2109233002/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
(right):

https://codereview.chromium.org/2109233002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:110:
/** @override */
On 2016/07/08 00:55:32, michaelpg wrote:
> do you get any other a11y errors when running these tests?
> 
> i've found "runAccessibilityChecks: false" on the prototype, like in
> SettingsPageBrowserTest, sometimes speeds up the test a lot.

I've disabled the a11y checks as you suggested. I noticed a few errors
when I changed them from warnings to errors. Made a comment to re-enable
when we make the warnings into errors. We may need to revisit how we run
the a11y tests with mocha. I think the a11y audit runs once per TEST_F
and each TEST_F right now runs multiple tests, which could lead to bad
a11y reporting.

https://codereview.chromium.org/2109233002/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:189:
TEST_F('SettingsAutofillSectionBrowserTest', 'creditCardTests', function() {
On 2016/07/08 00:55:32, michaelpg wrote:
> i think the convention is for the test in TEST_F to be CapitalCamelCase:
> CreditCardTests

Done.

[hcarmona, 2016-07-13 20:24:28]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-13 20:24:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2109233002/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2016-07-13 20:25:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 20:25:19]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names without "master." prefix is deprecated:
tryserver.chromium.linux. For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-13 21:01:45]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-13 21:42:53]

Description was changed from

==========
[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-07-13 21:42:54]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-13 21:43:13]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 21:45:49]

Description was changed from

==========
[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Add Edit/Create Address Dialog to MD Settings.

Change includes lots of tests.
Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70
Cr-Commit-Position: refs/heads/master@{#405303}
==========

[commit-bot: I haz the power, 2016-07-13 21:45:50]

Patchset 3 (id:??) landed as
https://crrev.com/3a206f090738b6e319eaa9caa1783687f636ed70
Cr-Commit-Position: refs/heads/master@{#405303}