[MD Settings] Allow saving addresses in material design settings.

[MD Settings] Allow saving addresses in material design settings.

Also fixes+tests issue that was causing save to fail in some cases.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/74a6064cb7c7f8f70ae2d7b6f24d143f1d568942
Cr-Commit-Position: refs/heads/master@{#405678}

[hcarmona, 2016-06-20 22:31:19]

Description was changed from

==========
[MD Settings] Allow saving addresses in material design settings.

Also fixes+tests issue that was causing save to fail in some cases.

BUG=607347
==========

to

==========
[MD Settings] Allow saving addresses in material design settings.

Also fixes+tests issue that was causing save to fail in some cases.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-06-21 00:14:48]

hcarmona@chromium.org changed reviewers:
+ michaelpg@chromium.org

[hcarmona, 2016-06-21 00:14:49]

This CL follows the previous one to allow saving the address that was edited.

[michaelpg, 2016-06-28 14:26:12]

does this need to be rebased or is it good to go?

[hcarmona, 2016-06-28 21:41:32]

On 2016/06/28 14:26:12, michaelpg wrote:
> does this need to be rebased or is it good to go?

Rebased, should be good now.

[michaelpg, 2016-06-29 00:00:28]

lgtm, some trivial comments

https://codereview.chromium.org/2082863002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2082863002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:121:
* @param {!AutofillManager.AddressEntry} creditCard
address

https://codereview.chromium.org/2082863002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
(right):

https://codereview.chromium.org/2082863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:419:
test('verifyPhoneAndEmailAreRemoved', function(done) {
optional: use promises instead of done

https://codereview.chromium.org/2082863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:428:
self.createAddressDialog_(address).then(function(dialog) {
return ...

[hcarmona, 2016-07-11 22:29:37]

Patchset #3 (id:40001) has been deleted

[hcarmona, 2016-07-11 22:35:13]

Patchset #3 (id:60001) has been deleted

[hcarmona, 2016-07-11 22:35:45]

Rebase + fix nits

https://codereview.chromium.org/2082863002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/2082863002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:121:
* @param {!AutofillManager.AddressEntry} creditCard
On 2016/06/29 00:00:28, michaelpg wrote:
> address

Done.

https://codereview.chromium.org/2082863002/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
(right):

https://codereview.chromium.org/2082863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:419:
test('verifyPhoneAndEmailAreRemoved', function(done) {
On 2016/06/29 00:00:28, michaelpg wrote:
> optional: use promises instead of done

Done.

https://codereview.chromium.org/2082863002/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/settings_autofill_section_browsertest.js:428:
self.createAddressDialog_(address).then(function(dialog) {
On 2016/06/29 00:00:28, michaelpg wrote:
> return ...

Done.

[hcarmona, 2016-07-13 18:24:09]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-13 18:24:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2082863002/#ps80001
(title: "nits")

[hcarmona, 2016-07-13 18:24:15]

The CQ bit was unchecked by hcarmona@chromium.org

[hcarmona, 2016-07-13 23:41:53]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:42:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 01:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:24:08]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hcarmona, 2016-07-14 23:49:08]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:49:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:49:36]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 02:22:20]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-15 02:23:39]

Description was changed from

==========
[MD Settings] Allow saving addresses in material design settings.

Also fixes+tests issue that was causing save to fail in some cases.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Allow saving addresses in material design settings.

Also fixes+tests issue that was causing save to fail in some cases.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/74a6064cb7c7f8f70ae2d7b6f24d143f1d568942
Cr-Commit-Position: refs/heads/master@{#405678}
==========

[commit-bot: I haz the power, 2016-07-15 02:23:40]

Patchset 3 (id:??) landed as
https://crrev.com/74a6064cb7c7f8f70ae2d7b6f24d143f1d568942
Cr-Commit-Position: refs/heads/master@{#405678}