[x64] Compare handles instead of code targets in emit_code_target.

[x64] Compare handles instead of code targets in emit_code_target.

This CL is on the way to extend parallel compilation of wasm modules to code generation. With parallel compilation it is not allowed to dereference handles during code generation. However, the is_identical_to check dereferences handles. In this CL we therefore replace the call to is_identical_to with a handle comparison.

Committed: https://crrev.com/4d631c8cd9193c38749eec9610f2bba0dcd76e16
Cr-Commit-Position: refs/heads/master@{#37607}

[ahaas, 2016-07-08 07:17:01]

Description was changed from

==========
reduce the identity check of code targets in emit_code_target

BUG=
==========

to

==========
This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.
==========

[ahaas, 2016-07-08 07:17:02]

ahaas@chromium.org changed reviewers:
+ bmeurer@chromium.org, mstarzinger@chromium.org, titzer@chromium.org

[ahaas, 2016-07-08 07:17:24]

PTAL

[Benedikt Meurer, 2016-07-08 07:17:51]

Description was changed from

==========
This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.
==========

to

==========
[x64] Compare handles instead of code targets in emit_code_target.

This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.
==========

[Benedikt Meurer, 2016-07-08 07:18:29]

LGTM once comment is addressed.

https://codereview.chromium.org/2109143002/diff/1/src/x64/assembler-x64-inl.h
File src/x64/assembler-x64-inl.h (right):

https://codereview.chromium.org/2109143002/diff/1/src/x64/assembler-x64-inl.h...
src/x64/assembler-x64-inl.h:68: if (current > 0 &&
code_targets_.last().location() == target.location()) {
Please use address() instead of location().

[ahaas, 2016-07-08 07:32:43]

https://codereview.chromium.org/2109143002/diff/1/src/x64/assembler-x64-inl.h
File src/x64/assembler-x64-inl.h (right):

https://codereview.chromium.org/2109143002/diff/1/src/x64/assembler-x64-inl.h...
src/x64/assembler-x64-inl.h:68: if (current > 0 &&
code_targets_.last().location() == target.location()) {
On 2016/07/08 at 07:18:29, Benedikt Meurer wrote:
> Please use address() instead of location().

Done.

[titzer, 2016-07-08 07:47:11]

On 2016/07/08 07:32:43, ahaas wrote:
> https://codereview.chromium.org/2109143002/diff/1/src/x64/assembler-x64-inl.h
> File src/x64/assembler-x64-inl.h (right):
> 
>
https://codereview.chromium.org/2109143002/diff/1/src/x64/assembler-x64-inl.h...
> src/x64/assembler-x64-inl.h:68: if (current > 0 &&
> code_targets_.last().location() == target.location()) {
> On 2016/07/08 at 07:18:29, Benedikt Meurer wrote:
> > Please use address() instead of location().
> 
> Done.

lgtm

[ahaas, 2016-07-08 09:40:23]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-07-08 09:40:23]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2109143002/#ps20001
(title: "Use address instead of location.")

[commit-bot: I haz the power, 2016-07-08 09:40:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 10:32:29]

Description was changed from

==========
[x64] Compare handles instead of code targets in emit_code_target.

This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.
==========

to

==========
[x64] Compare handles instead of code targets in emit_code_target.

This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.
==========

[commit-bot: I haz the power, 2016-07-08 10:32:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 10:33:26]

Description was changed from

==========
[x64] Compare handles instead of code targets in emit_code_target.

This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.
==========

to

==========
[x64] Compare handles instead of code targets in emit_code_target.

This CL is on the way to extend parallel compilation of wasm modules to code
generation. With parallel compilation it is not allowed to dereference handles
during code generation. However, the is_identical_to check dereferences handles.
In this CL we therefore replace the call to is_identical_to with a handle
comparison.

Committed: https://crrev.com/4d631c8cd9193c38749eec9610f2bba0dcd76e16
Cr-Commit-Position: refs/heads/master@{#37607}
==========

[commit-bot: I haz the power, 2016-07-08 10:33:27]

Patchset 2 (id:??) landed as
https://crrev.com/4d631c8cd9193c38749eec9610f2bba0dcd76e16
Cr-Commit-Position: refs/heads/master@{#37607}