src/x64/assembler-x64-inl.h - Issue 2109143002: [x64] Compare handles instead of code targets in emit_code_target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 2109143002: [x64] Compare handles instead of code targets in emit_code_target. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Use address instead of location. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index a7256565f1d9b8e3803221de5ff41c6feb9a3b4a..dd583cc346a7f8fa2a2480e0cc3c26079a5859e8 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -65,7 +65,7 @@ void Assembler::emit_code_target(Handle<Code> target,

RecordRelocInfo(rmode);

}

int current = code_targets_.length();

- if (current > 0 && code_targets_.last().is_identical_to(target)) {

+ if (current > 0 && code_targets_.last().address() == target.address()) {

// Optimization if we keep jumping to the same code target.

emitl(current - 1);

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »