Make Text::updateLayoutTextObject() to handle first-letter pseudo element correctly

Make Text::updateLayoutTextObject() to update first-letter pseudo element related layout tree correctly

This patch makes |Text::updateTextLayoutObject()| to reattach layout object for
|Text| node when it is part of first-letter when contents of |Text| node is
changed.

Before this patch, we change |LayoutTextFragment| directly and leaves original
first letter part event if |Text| node no more to serve first-letter part, e.g.
change to "a" (first-letter part), to " " (a space isn't first-letter part).

This patch covers more cases than crrev.com/380116, which covers text change
to make no first-letter pseudo element.

BUG=619379
TEST=webkit_unit_tests --gtest_filter=TextTest.SetDataToChangeFirstLetterTextNode

Committed: https://crrev.com/1823f9957dd146fd14cec6ec8c549364fbc4fbfd
Cr-Commit-Position: refs/heads/master@{#402775}

[yosin_UTC9, 2016-06-29 06:56:00]

Description was changed from

==========
2016-06-29T15:54:22

BUG=
==========

to

==========
Make Text::updateLayoutTextObject() to update first-letter pseudo element
related layout tree correctly

This patch makes |Text::updateTextLayoutObject()| to reattach layout object for
|Text| node when it is part of first-letter when contents of |Text| node is
changed.

Before this patch, we change |LayoutTextFragment| directly and leaves original
first letter part event if |Text| node no more to serve first-letter part, e.g.
change to "a" (first-letter part), to " " (a space isn't first-letter part).

BUG=619379
TEST=webkit_unit_tests
--gtest_filter=TextTest.SetDataToChangeFirstLetterTextNode
==========

[yosin_UTC9, 2016-06-29 06:59:05]

Description was changed from

==========
Make Text::updateLayoutTextObject() to update first-letter pseudo element
related layout tree correctly

This patch makes |Text::updateTextLayoutObject()| to reattach layout object for
|Text| node when it is part of first-letter when contents of |Text| node is
changed.

Before this patch, we change |LayoutTextFragment| directly and leaves original
first letter part event if |Text| node no more to serve first-letter part, e.g.
change to "a" (first-letter part), to " " (a space isn't first-letter part).

BUG=619379
TEST=webkit_unit_tests
--gtest_filter=TextTest.SetDataToChangeFirstLetterTextNode
==========

to

==========
Make Text::updateLayoutTextObject() to update first-letter pseudo element
related layout tree correctly

This patch makes |Text::updateTextLayoutObject()| to reattach layout object for
|Text| node when it is part of first-letter when contents of |Text| node is
changed.

Before this patch, we change |LayoutTextFragment| directly and leaves original
first letter part event if |Text| node no more to serve first-letter part, e.g.
change to "a" (first-letter part), to " " (a space isn't first-letter part).

This patch covers more cases than crrev.com/380116, which covers text change
to make no first-letter pseudo element.

BUG=619379
TEST=webkit_unit_tests
--gtest_filter=TextTest.SetDataToChangeFirstLetterTextNode
==========

[yosin_UTC9, 2016-06-29 07:37:58]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2016-06-29 07:37:59]

PTAL

[tkent, 2016-06-29 08:27:38]

https://codereview.chromium.org/2109073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Text.cpp (right):

https://codereview.chromium.org/2109073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Text.cpp:418: if
(!toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement()) {
The new code is equivalent to
    return toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement();
right?

[yosin_UTC9, 2016-06-29 08:41:10]

PTAL

https://codereview.chromium.org/2109073002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/Text.cpp (right):

https://codereview.chromium.org/2109073002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/Text.cpp:418: if
(!toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement()) {
On 2016/06/29 at 08:27:38, tkent wrote:
> The new code is equivalent to
>     return toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement();
> right?

Yes, it seems my brain is damaged... :-<

[tkent, 2016-06-29 08:44:49]

lgtm

[yosin_UTC9, 2016-06-29 09:14:41]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-06-29 09:14:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 11:09:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 11:12:08]

Description was changed from

==========
Make Text::updateLayoutTextObject() to update first-letter pseudo element
related layout tree correctly

This patch makes |Text::updateTextLayoutObject()| to reattach layout object for
|Text| node when it is part of first-letter when contents of |Text| node is
changed.

Before this patch, we change |LayoutTextFragment| directly and leaves original
first letter part event if |Text| node no more to serve first-letter part, e.g.
change to "a" (first-letter part), to " " (a space isn't first-letter part).

This patch covers more cases than crrev.com/380116, which covers text change
to make no first-letter pseudo element.

BUG=619379
TEST=webkit_unit_tests
--gtest_filter=TextTest.SetDataToChangeFirstLetterTextNode
==========

to

==========
Make Text::updateLayoutTextObject() to update first-letter pseudo element
related layout tree correctly

This patch makes |Text::updateTextLayoutObject()| to reattach layout object for
|Text| node when it is part of first-letter when contents of |Text| node is
changed.

Before this patch, we change |LayoutTextFragment| directly and leaves original
first letter part event if |Text| node no more to serve first-letter part, e.g.
change to "a" (first-letter part), to " " (a space isn't first-letter part).

This patch covers more cases than crrev.com/380116, which covers text change
to make no first-letter pseudo element.

BUG=619379
TEST=webkit_unit_tests
--gtest_filter=TextTest.SetDataToChangeFirstLetterTextNode

Committed: https://crrev.com/1823f9957dd146fd14cec6ec8c549364fbc4fbfd
Cr-Commit-Position: refs/heads/master@{#402775}
==========

[commit-bot: I haz the power, 2016-06-29 11:12:09]

Patchset 2 (id:??) landed as
https://crrev.com/1823f9957dd146fd14cec6ec8c549364fbc4fbfd
Cr-Commit-Position: refs/heads/master@{#402775}