Make Text::updateLayoutTextObject() to handle first-letter pseudo element correctly

third_party/WebKit/Source/core/dom/Text.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 397 matching lines @@
 // Passing both |textNode| and its layout object because repeated calls to
 // |Node::layoutObject()| are discouraged.
 static bool shouldUpdateLayoutByReattaching(const Text& textNode, LayoutText* textLayoutObject)
 {
     DCHECK_EQ(textNode.layoutObject(), textLayoutObject);
     if (!textLayoutObject)
         return true;
     if (!textNode.textLayoutObjectIsNeeded(*textLayoutObject->style(), *textLayoutObject->parent()))
         return true;
     if (textLayoutObject->isTextFragment()) {
-        FirstLetterPseudoElement* pseudo = toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement();
-        if (pseudo && !FirstLetterPseudoElement::firstLetterTextLayoutObject(*pseudo))
-            return true;
+        if (!toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement()) {

[tkent, 2016/06/29 08:27:38]

The new code is equivalent to
    return toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement();
right?

[yosin_UTC9, 2016/06/29 08:41:10]

Yes, it seems my brain is damaged... :-<

+            // When |textLayoutObject| isn't associated to first-letter, we
+            // change |textLayoutObject| directly.
+            return false;
+        }
+        // Changes of |textNode| may change first letter part, so we should
+        // reattach.
+        return toLayoutTextFragment(textLayoutObject)->firstLetterPseudoElement();
     }
     return false;
 }
 
 void Text::updateTextLayoutObject(unsigned offsetOfReplacedData, unsigned lengthOfReplacedData, RecalcStyleBehavior recalcStyleBehavior)
 {
     if (!inActiveDocument())
         return;
     LayoutText* textLayoutObject = layoutObject();
     if (shouldUpdateLayoutByReattaching(*this, textLayoutObject)) {
@@ skipping 30 matching lines @@
             result.append("; ");
         result.append("value=");
         result.append(s);
     }
 
     strncpy(buffer, result.toString().utf8().data(), length - 1);
 }
 #endif
 
 } // namespace blink