Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109043002: Eliminate the ChannelMojo channel for renderers (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate the ChannelMojo channel for renderers, instead obtain Bootstrap interface from child connection. R=rockot@chromium.org http://crbug.com/623396 BUG= Committed: https://crrev.com/9e883c385ccc47607a9341d618678b35195cc8fe Cr-Commit-Position: refs/heads/master@{#402812}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M content/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 3 chunks +22 lines, -6 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/content_child.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2112543002 Patch 1

Messages

Total messages: 12 (5 generated)
Ben Goodger (Google)
OK Ken, had to re-spin this due to issues. Now with green try runs!
4 years, 5 months ago (2016-06-29 13:47:34 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 5 months ago (2016-06-29 14:49:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109043002/60001
4 years, 5 months ago (2016-06-29 15:02:28 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-29 15:07:34 UTC) #8
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/9e883c385ccc47607a9341d618678b35195cc8fe Cr-Commit-Position: refs/heads/master@{#402812}
4 years, 5 months ago (2016-06-29 15:09:47 UTC) #10
boliu
Hi, is this safe to revert? Please see https://bugs.chromium.org/p/chromium/issues/detail?id=624556#c16 Sorry those tests aren't on cq ...
4 years, 5 months ago (2016-06-30 16:05:18 UTC) #11
Ken Rockot(use gerrit already)
4 years, 5 months ago (2016-06-30 16:08:38 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2111673006/ by rockot@chromium.org.

The reason for reverting is: http://crbug.com/624556.

Powered by Google App Engine
This is Rietveld 408576698