Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2112543002: Convert UtilityProcessHost to bootstrap Mojo Channel using the Shell connection (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@p9x
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert UtilityProcessHost to bootstrap Mojo Channel using the Shell connection R=rockot@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Total comments: 1

Patch Set 9 : . #

Patch Set 10 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -32 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_test_base.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service_test_base.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 2 3 4 5 6 7 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/zipfile_installer_unittest.cc View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/download_protection_service_unittest.cc View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/sandboxed_dmg_analyzer_mac_unittest.cc View 1 2 3 4 5 6 7 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer_unittest.cc View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 3 chunks +2 lines, -2 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 1 2 3 4 5 6 7 8 9 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 2 3 3 chunks +13 lines, -7 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A content/public/browser/shell_context.h View 1 2 3 4 5 6 1 chunk +36 lines, -0 lines 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/extensions_test.cc View 1 2 3 4 5 6 7 2 chunks +22 lines, -1 line 0 comments Download
M extensions/browser/sandboxed_unpacker_unittest.cc View 1 2 3 4 5 6 7 3 chunks +5 lines, -0 lines 0 comments Download
M services/shell/shell.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ben Goodger (Google)
4 years, 5 months ago (2016-06-29 22:17:02 UTC) #1
Ben Goodger (Google)
On 2016/06/29 22:17:02, Ben Goodger (Google) wrote: I still have one outstanding test that I'm ...
4 years, 5 months ago (2016-06-30 06:02:13 UTC) #2
Ben Goodger (Google)
On 2016/06/30 06:02:13, Ben Goodger (Google) wrote: > On 2016/06/29 22:17:02, Ben Goodger (Google) wrote: ...
4 years, 5 months ago (2016-06-30 14:30:48 UTC) #3
Ben Goodger (Google)
On 2016/06/30 14:30:48, Ben Goodger (Google) wrote: > On 2016/06/30 06:02:13, Ben Goodger (Google) wrote: ...
4 years, 5 months ago (2016-06-30 14:40:43 UTC) #4
Ken Rockot(use gerrit already)
LGTM I was going to complain that it's kind of unclear as a casual reader ...
4 years, 5 months ago (2016-06-30 14:50:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2112543002/180001
4 years, 5 months ago (2016-06-30 15:25:04 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 16:06:56 UTC) #10
Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698