Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2108983002: Use ContextUtils in PhysicalWeb (Closed)

Created:
4 years, 5 months ago by cco3
Modified:
4 years, 5 months ago
Reviewers:
nyquist, gone, mattreynolds
CC:
chromium-reviews, gayane+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContextUtils in PhysicalWeb The Physical Web code currently requires a lot of passing around Contexts where not necessary because we just want the Application. This change uses ContextUtils.getApplicationContext() when applicable. BUG=624204 Committed: https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e Cr-Commit-Position: refs/heads/master@{#404238}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Add a necessary @VisibleForTesting #

Patch Set 4 : Update tests to use new methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -73 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ClearNotificationAlarmReceiver.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java View 5 chunks +5 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWeb.java View 1 5 chunks +17 lines, -33 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java View 3 7 chunks +20 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PhysicalWebPreferenceFragment.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivityTest.java View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 27 (12 generated)
cco3
4 years, 5 months ago (2016-06-29 00:33:10 UTC) #2
mattreynolds
https://codereview.chromium.org/2108983002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2108983002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java#newcode136 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:136: public static UrlManager getInstance(Context context) { When can this ...
4 years, 5 months ago (2016-06-29 00:48:10 UTC) #3
cco3
https://codereview.chromium.org/2108983002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java (right): https://codereview.chromium.org/2108983002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java#newcode136 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/UrlManager.java:136: public static UrlManager getInstance(Context context) { On 2016/06/29 00:48:10, ...
4 years, 5 months ago (2016-06-29 16:36:00 UTC) #4
cco3
Hi nyquist@, would you be able to review this code cleanup change?
4 years, 5 months ago (2016-06-29 16:36:38 UTC) #6
mattreynolds
lgtm
4 years, 5 months ago (2016-06-29 21:16:15 UTC) #7
cco3
4 years, 5 months ago (2016-07-06 21:54:06 UTC) #9
gone
lgtm
4 years, 5 months ago (2016-07-06 22:00:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108983002/20001
4 years, 5 months ago (2016-07-06 22:24:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/99412)
4 years, 5 months ago (2016-07-07 03:10:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108983002/40001
4 years, 5 months ago (2016-07-07 17:25:21 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/188935)
4 years, 5 months ago (2016-07-07 18:08:35 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108983002/60001
4 years, 5 months ago (2016-07-07 18:57:26 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-07 22:04:57 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 22:05:37 UTC) #25
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 22:06:38 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b444c43df71f607a72e47e234d23801c5bdff42e
Cr-Commit-Position: refs/heads/master@{#404238}

Powered by Google App Engine
This is Rietveld 408576698