chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java - Issue 2108983002: Use ContextUtils in PhysicalWeb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Issue 2108983002: Use ContextUtils in PhysicalWeb (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update tests to use new methods Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebUma.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

index 69eff5569d65f814c0f00d036711934ee9b46e3e..836e46b46e13f34ded5a136749100780ac840d21 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

@@ -104,8 +104,8 @@ public class PhysicalWebDiagnosticsPage implements NativePage {

LocationUtils locationUtils = LocationUtils.getInstance();

boolean isLocationServicesEnabled = locationUtils.isSystemLocationSettingEnabled(mContext);

boolean isLocationPermissionGranted = locationUtils.hasAndroidLocationPermission(mContext);

- boolean isPreferenceEnabled = PhysicalWeb.isPhysicalWebPreferenceEnabled(mContext);

- boolean isOnboarding = PhysicalWeb.isOnboarding(mContext);

+ boolean isPreferenceEnabled = PhysicalWeb.isPhysicalWebPreferenceEnabled();

+ boolean isOnboarding = PhysicalWeb.isOnboarding();

int prerequisitesResult = Utils.RESULT_SUCCESS;

if (!isSdkVersionCorrect

@@ -156,7 +156,7 @@ public class PhysicalWebDiagnosticsPage implements NativePage {

}

private void appendUrlManagerReport(StringBuilder sb) {

- UrlManager urlManager = UrlManager.getInstance(mContext);

+ UrlManager urlManager = UrlManager.getInstance();

Set<String> nearbyUrls = new HashSet<>(urlManager.getNearbyUrls());

Set<String> resolvedUrls = new HashSet<>(urlManager.getResolvedUrls());