Initial draft of ChromeVox Next tutorial.

Initial draft of ChromeVox Next tutorial.

This just tries to get all of the text on the screen. It doesn't work
perfectly yet.

BUG=618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/daa4b8eb0d07f6d747f69b2b6fb87d16c2cbae93
Cr-Commit-Position: refs/heads/master@{#403027}

[dmazzoni, 2016-06-29 19:58:24]

Description was changed from

==========
Initial draft of ChromeVox Next tutorial.

This just tries to get all of the text on the screen. It doesn't work
perfectly yet.

BUG=618090
==========

to

==========
Initial draft of ChromeVox Next tutorial.

This just tries to get all of the text on the screen. It doesn't work
perfectly yet.

BUG=618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dmazzoni, 2016-06-29 19:58:55]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2016-06-29 20:59:43]

We should talk through the way a user gets to the tutorial. If you'd like to get
the strings in first, I'm in favor of that.

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:575:
"command": "help",
I already added a showUpdatePage command.

The user flow I was going for was the following:
User always starts off in Classic. As soon as a user turns on ChromeVox, he/she
gets alerted via a message center notification of changes in ChromeVox. Hitting
Search+o, n will get the user to the page (this can be the tutorial).

In this cl, a user would only get tot the tutorial if they clicked on the
message and not via the key.

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
(right):

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js:799:
case 'help':
Shoudl this be called openTutorial?

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js
(left):

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js:47:
chrome.tabs.create(nextUpdatePage);
Can you delete this file (if you're not planning on using it). It was meant as a
placeholder.

[dmazzoni, 2016-06-29 22:51:35]

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json
(right):

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json:575:
"command": "help",
On 2016/06/29 20:59:43, David Tseng wrote:
> I already added a showUpdatePage command.
> 
> The user flow I was going for was the following:
> User always starts off in Classic. As soon as a user turns on ChromeVox,
he/she
> gets alerted via a message center notification of changes in ChromeVox.
Hitting
> Search+o, n will get the user to the page (this can be the tutorial).
> 
> In this cl, a user would only get tot the tutorial if they clicked on the
> message and not via the key.

Got it. Switched it so that showNextUpdatePage opens the tutorial.

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js
(left):

https://codereview.chromium.org/2108963003/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/notifications.js:47:
chrome.tabs.create(nextUpdatePage);
On 2016/06/29 20:59:43, David Tseng wrote:
> Can you delete this file (if you're not planning on using it). It was meant as
a
> placeholder.

Done.

[David Tseng, 2016-06-29 22:55:01]

lgtm

[dmazzoni, 2016-06-29 22:55:28]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-06-29 22:56:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:29:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-30 00:31:51]

Description was changed from

==========
Initial draft of ChromeVox Next tutorial.

This just tries to get all of the text on the screen. It doesn't work
perfectly yet.

BUG=618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Initial draft of ChromeVox Next tutorial.

This just tries to get all of the text on the screen. It doesn't work
perfectly yet.

BUG=618090
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/daa4b8eb0d07f6d747f69b2b6fb87d16c2cbae93
Cr-Commit-Position: refs/heads/master@{#403027}
==========

[commit-bot: I haz the power, 2016-06-30 00:31:52]

Patchset 4 (id:??) landed as
https://crrev.com/daa4b8eb0d07f6d747f69b2b6fb87d16c2cbae93
Cr-Commit-Position: refs/heads/master@{#403027}