device: Change auto to not deduce raw pointers.

device/bluetooth/bluetooth_adapter.cc

Index: device/bluetooth/bluetooth_adapter.cc
diff --git a/device/bluetooth/bluetooth_adapter.cc b/device/bluetooth/bluetooth_adapter.cc
index 6d997515ac3162344e91d835b5d74c4a4fc052a5..7b30fad19ebd8a1f5ce5d300142767bf306fe234 100644
--- a/device/bluetooth/bluetooth_adapter.cc
+++ b/device/bluetooth/bluetooth_adapter.cc
@@ -336,7 +336,7 @@ BluetoothAdapter::GetMergedDiscoveryFilterHelper(
   bool first_merge = true;
 
   std::set<BluetoothDiscoverySession*> temp(discovery_sessions_);
-  for (const auto& iter : temp) {
+  for (auto* iter : temp) {

[ortuno, 2016/06/28 21:38:17]

I've been told in the past that I shouldn't use auto for pointers. Does that no
longer apply?

[vmpstr, 2016/06/28 21:43:13]

This holds, but it's a bit subtle. In the case before, auto was deducing to be a
pointer type. That is, |iter| was a const reference to a pointer type (pointer
type written as "auto"). The change here is to move the "pointer" part outside
of the "auto" part. So now, auto deduces to some concrete type, but |iter| is
still a pointer to that type. 

[danakj, 2016/06/28 22:06:44]

FWIW past guidance on chromium-dev has been to not use auto for *smart* pointers
aka std::unique_ptr/scoped_refptr.

     const BluetoothDiscoveryFilter* curr_filter = iter->GetDiscoveryFilter();
 
     if (!iter->IsActive())