device: Change auto to not deduce raw pointers.

device/bluetooth/bluetooth_adapter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_adapter.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 318 matching lines @@
 }
 
 std::unique_ptr<BluetoothDiscoveryFilter>
 BluetoothAdapter::GetMergedDiscoveryFilterHelper(
     const BluetoothDiscoveryFilter* masked_filter,
     bool omit) const {
   std::unique_ptr<BluetoothDiscoveryFilter> result;
   bool first_merge = true;
 
   std::set<BluetoothDiscoverySession*> temp(discovery_sessions_);
-  for (const auto& iter : temp) {
+  for (auto* iter : temp) {

[ortuno, 2016/06/28 21:38:17]

I've been told in the past that I shouldn't use auto for pointers. Does that no
longer apply?

[vmpstr, 2016/06/28 21:43:13]

This holds, but it's a bit subtle. In the case before, auto was deducing to be a
pointer type. That is, |iter| was a const reference to a pointer type (pointer
type written as "auto"). The change here is to move the "pointer" part outside
of the "auto" part. So now, auto deduces to some concrete type, but |iter| is
still a pointer to that type. 

[danakj, 2016/06/28 22:06:44]

FWIW past guidance on chromium-dev has been to not use auto for *smart* pointers
aka std::unique_ptr/scoped_refptr.

     const BluetoothDiscoveryFilter* curr_filter = iter->GetDiscoveryFilter();
 
     if (!iter->IsActive())
       continue;
 
     if (omit && curr_filter == masked_filter) {
       // if masked_filter is pointing to empty filter, and there are
       // multiple empty filters in discovery_sessions_, make sure we'll
       // process next empty sessions.
       omit = false;
@@ skipping 61 matching lines @@
   UMA_HISTOGRAM_ENUMERATION(
       "Bluetooth.DiscoverySession.Stop.Outcome", static_cast<int>(outcome),
       static_cast<int>(UMABluetoothDiscoverySessionOutcome::COUNT));
 }
 
 // static
 const base::TimeDelta BluetoothAdapter::timeoutSec =
     base::TimeDelta::FromSeconds(180);
 
 }  // namespace device