device: Change auto to not deduce raw pointers.

device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg@chromium.org
BUG=554600
Committed: https://crrev.com/b0e145b14f1ae5821f187e2297e538ac56c763dc
Cr-Commit-Position: refs/heads/master@{#408321}

[vmpstr, 2016-06-28 21:25:06]

Description was changed from

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg, danakj, dcheng
BUG=554600
==========

to

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=jam, danakj, dcheng
BUG=554600
==========

[vmpstr, 2016-06-28 21:25:06]

vmpstr@chromium.org changed reviewers:
+ jam@chromium.org
- reillyg@google.com

[vmpstr, 2016-06-28 21:25:41]

Please take a look.

[ortuno, 2016-06-28 21:38:17]

ortuno@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-06-28 21:38:18]

https://codereview.chromium.org/2108923002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter.cc (right):

https://codereview.chromium.org/2108923002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter.cc:339: for (auto* iter : temp) {
I've been told in the past that I shouldn't use auto for pointers. Does that no
longer apply?

[vmpstr, 2016-06-28 21:43:13]

https://codereview.chromium.org/2108923002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter.cc (right):

https://codereview.chromium.org/2108923002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter.cc:339: for (auto* iter : temp) {
On 2016/06/28 21:38:17, ortuno wrote:
> I've been told in the past that I shouldn't use auto for pointers. Does that
no
> longer apply?

This holds, but it's a bit subtle. In the case before, auto was deducing to be a
pointer type. That is, |iter| was a const reference to a pointer type (pointer
type written as "auto"). The change here is to move the "pointer" part outside
of the "auto" part. So now, auto deduces to some concrete type, but |iter| is
still a pointer to that type.

[danakj, 2016-06-28 22:06:44]

https://codereview.chromium.org/2108923002/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_adapter.cc (right):

https://codereview.chromium.org/2108923002/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_adapter.cc:339: for (auto* iter : temp) {
On 2016/06/28 21:43:13, vmpstr wrote:
> On 2016/06/28 21:38:17, ortuno wrote:
> > I've been told in the past that I shouldn't use auto for pointers. Does that
> no
> > longer apply?

FWIW past guidance on chromium-dev has been to not use auto for *smart* pointers
aka std::unique_ptr/scoped_refptr.

> This holds, but it's a bit subtle. In the case before, auto was deducing to be
a
> pointer type. That is, |iter| was a const reference to a pointer type (pointer
> type written as "auto"). The change here is to move the "pointer" part outside
> of the "auto" part. So now, auto deduces to some concrete type, but |iter| is
> still a pointer to that type.

[jam, 2016-06-29 17:05:11]

not sure why I'm added here?

[vmpstr, 2016-06-29 20:40:21]

Description was changed from

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=jam, danakj, dcheng
BUG=554600
==========

to

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=danakj, dcheng
BUG=554600
==========

[vmpstr, 2016-06-29 20:40:22]

vmpstr@chromium.org changed reviewers:
- jam@chromium.org

[vmpstr, 2016-07-26 01:12:23]

Description was changed from

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=danakj, dcheng
BUG=554600
==========

to

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg@chromium.org
BUG=554600
==========

[vmpstr, 2016-07-26 01:12:23]

vmpstr@chromium.org changed reviewers:
+ reillyg@chromium.org
- danakj@chromium.org, dcheng@chromium.org, ortuno@chromium.org

[vmpstr, 2016-07-26 01:12:54]

I've rebased this and +reillyg for review. Please take a look.

[Reilly Grant (use Gerrit), 2016-07-27 19:45:22]

lgtm

[vmpstr, 2016-07-28 01:02:28]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2016-07-28 01:02:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 02:55:51]

Description was changed from

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg@chromium.org
BUG=554600
==========

to

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg@chromium.org
BUG=554600
==========

[commit-bot: I haz the power, 2016-07-28 02:55:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-28 02:58:42]

Description was changed from

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg@chromium.org
BUG=554600
==========

to

==========
device: Change auto to not deduce raw pointers.

This patch updates the code to prevent auto deducing to a raw pointer.

R=reillyg@chromium.org
BUG=554600

Committed: https://crrev.com/b0e145b14f1ae5821f187e2297e538ac56c763dc
Cr-Commit-Position: refs/heads/master@{#408321}
==========

[commit-bot: I haz the power, 2016-07-28 02:58:43]

Patchset 2 (id:??) landed as
https://crrev.com/b0e145b14f1ae5821f187e2297e538ac56c763dc
Cr-Commit-Position: refs/heads/master@{#408321}