Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2108883004: Remove LayerTreeImpl::SetRootLayerFromLayerListForTesting. (Closed)

Created:
4 years, 5 months ago by danakj
Modified:
4 years, 5 months ago
Reviewers:
jaydasika, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@propertytreestuff
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LayerTreeImpl::SetRootLayerFromLayerListForTesting. Calling this implies you have a layer list, but the root layer is used to generate a layer list. And if you don't have test_properties() set up correctly, you'd end up clobbering the good list with a bad one. R=ajuma, jaydasika@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/0da42ca698fa681f43e7bed788140aa11391bba8 Cr-Commit-Position: refs/heads/master@{#403504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108883004/1
4 years, 5 months ago (2016-06-29 23:49:58 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 01:05:29 UTC) #5
danakj
jay can you review? thanks :)
4 years, 5 months ago (2016-07-01 02:11:39 UTC) #6
jaydasika
lgtm
4 years, 5 months ago (2016-07-01 02:20:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108883004/1
4 years, 5 months ago (2016-07-01 18:54:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 19:42:57 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 19:43:07 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 19:46:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0da42ca698fa681f43e7bed788140aa11391bba8
Cr-Commit-Position: refs/heads/master@{#403504}

Powered by Google App Engine
This is Rietveld 408576698