cc: Change how/when we build layer list/property tress in tests.

cc: Change how/when we build layer list/property tress in tests.

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/74af409e25e40c016fba195af1adc53e3dce856f
Cr-Commit-Position: refs/heads/master@{#403375}

[danakj, 2016-06-29 22:21:11]

Description was changed from

==========
cc: Change how/when we build layer list/property tress in tests.

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
==========

to

==========
cc: Change how/when we build layer list/property tress in tests.

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-06-29 22:21:12]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 22:23:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-06-29 22:40:45]

lgtm if the bots are happy.

https://codereview.chromium.org/2106273002/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2106273002/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:1025: void
LayerTreeImpl::BuildLayerListAndPropertyTreesForTesting() {
This can now just be :
BuildLayerListForTesting();
BuildPropertyTreesFortTesting();

[danakj, 2016-06-29 22:41:39]

Changed all the BuildLayerListAndPropertyTrees in LayerTreeHostImpl tests to
just BuildPropertyTrees also in the 2nd patch set, as the layer lists are
already built!

[danakj, 2016-06-29 22:42:18]

https://codereview.chromium.org/2106273002/diff/1/cc/trees/layer_tree_impl.cc
File cc/trees/layer_tree_impl.cc (right):

https://codereview.chromium.org/2106273002/diff/1/cc/trees/layer_tree_impl.cc...
cc/trees/layer_tree_impl.cc:1025: void
LayerTreeImpl::BuildLayerListAndPropertyTreesForTesting() {
On 2016/06/29 22:40:45, jaydasika wrote:
> This can now just be :
> BuildLayerListForTesting();
> BuildPropertyTreesFortTesting();

Oh sure, ya :)

[danakj, 2016-06-29 22:47:44]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-06-29 22:47:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
jaydasika@chromium.org
Link to the patchset: https://codereview.chromium.org/2106273002/#ps40001
(title: "propertytreestuff: .")

[commit-bot: I haz the power, 2016-06-29 22:49:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 23:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:41:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-06-29 23:53:13]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-06-29 23:54:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 00:43:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 00:43:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-06-30 00:46:43]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-06-30 00:47:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-06-30 00:47:45]

Um. A chromevox_tests test failed twice with my patch, with this: 

[17759:17759:0629/171320:FATAL:keep_alive_registry.cc(53)] Check failed:
!g_browser_process->IsShuttingDown(). 

I don't comprehend how changing cc unittests would do this. So.. try again?

[commit-bot: I haz the power, 2016-06-30 01:30:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 01:30:17]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-06-30 22:32:50]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 22:33:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-06-30 23:20:15]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-06-30 23:20:19]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-06-30 23:20:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 00:42:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-01 00:42:07]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-01 00:44:29]

Description was changed from

==========
cc: Change how/when we build layer list/property tress in tests.

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Change how/when we build layer list/property tress in tests.

There's a bug where when you activate a pending tree, the active
tree does not get the test_properties(), so if you BuildLayerList on
the active tree, the layer list drops all its layers except the root.

In fixing this, I struggled with understanding where and when tests are
building layer lists and property trees, and made some changes.

Now the test properties build the layer list when AddChild/RemoveChild
happens, which is consistent with SetRootLayerForTesting.

Also, the BuildLayerListAndPropertyTreesForTesting() and (the new)
BuildPropertyTreesForTesting() methods will now always build the trees
by setting needs_rebuild = true internally.

Also, cleaned up a bunch of LayerTreeHostImpl tests, to not have special
PrepareToDraw paths that build property trees, and just do it in the
tests.

R=ajuma, jaydasika@chromium.org
BUG=311404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/74af409e25e40c016fba195af1adc53e3dce856f
Cr-Commit-Position: refs/heads/master@{#403375}
==========

[commit-bot: I haz the power, 2016-07-01 00:44:30]

Patchset 3 (id:??) landed as
https://crrev.com/74af409e25e40c016fba195af1adc53e3dce856f
Cr-Commit-Position: refs/heads/master@{#403375}