chrome/browser/extensions/unpacked_installer.h - Issue 2108853002: Restrict use of two app-launching command line flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.h

Issue 2108853002: Restrict use of two app-launching command line flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add /* explanation */ for the bool parameter Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« apps/load_and_launch_browsertest.cc ('K') | « chrome/browser/extensions/extension_system_impl.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.h

diff --git a/chrome/browser/extensions/unpacked_installer.h b/chrome/browser/extensions/unpacked_installer.h

index 2bdc85eb931dbfbad8b2bc745a0b49060354461d..602ec6eb354b5d4c1bbcaa640dc830197439fa31 100644

--- a/chrome/browser/extensions/unpacked_installer.h

+++ b/chrome/browser/extensions/unpacked_installer.h

@@ -51,7 +51,8 @@ class UnpackedInstaller

// The return value indicates whether the installation has begun successfully.

// The id of the extension being loaded is returned in |extension_id|.

bool LoadFromCommandLine(const base::FilePath& extension_path,

- std::string* extension_id);

+ std::string* extension_id,

+ bool only_allow_apps);

msw 2016/07/21 17:13:50 nit: comment above: "used to avoid side-loading no

proberge 2016/07/25 20:40:53 Done.

// Allows prompting for plugins to be disabled; intended for testing only.

bool prompt_for_plugins() { return prompt_for_plugins_; }

« apps/load_and_launch_browsertest.cc ('K') | « chrome/browser/extensions/extension_system_impl.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | no next file with comments »