chrome/browser/extensions/extension_system_impl.cc - Issue 2108853002: Restrict use of two app-launching command line flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_system_impl.cc

Issue 2108853002: Restrict use of two app-launching command line flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add /* explanation */ for the bool parameter Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« apps/load_and_launch_browsertest.cc ('K') | « apps/load_and_launch_browsertest.cc ('k') | chrome/browser/extensions/unpacked_installer.h » ('j') | chrome/browser/extensions/unpacked_installer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_system_impl.cc

diff --git a/chrome/browser/extensions/extension_system_impl.cc b/chrome/browser/extensions/extension_system_impl.cc

index fa7596f5ad8971e9170674d058eb884391aea2e6..7ad271fb3f43013de9764883fb31efe972d087de 100644

--- a/chrome/browser/extensions/extension_system_impl.cc

+++ b/chrome/browser/extensions/extension_system_impl.cc

@@ -275,8 +275,9 @@ void ExtensionSystemImpl::Shared::Init(bool extensions_enabled) {

t(path_list, FILE_PATH_LITERAL(","));

while (t.GetNext()) {

std::string extension_id;

- UnpackedInstaller::Create(extension_service_.get())->

- LoadFromCommandLine(base::FilePath(t.token()), &extension_id);

+ UnpackedInstaller::Create(extension_service_.get())

+ ->LoadFromCommandLine(base::FilePath(t.token()), &extension_id,

+ false /* only_allow_apps */);

}