Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2108833002: Remove Simplify Page option from Print Preview (Closed)

Created:
4 years, 5 months ago by Lei Zhang
Modified:
4 years, 5 months ago
CC:
chromium-reviews, arv+watch_chromium.org, Alexei Svitkine (slow), mvendramini_hp, arjunpatel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Simplify Page option from Print Preview BUG=620382 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a223560fd493a9f25d23a33bd624328b6eec854a Cr-Commit-Position: refs/heads/master@{#402876}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : less and more #

Total comments: 3

Patch Set 4 : Fix PrintPreviewDialogController #

Patch Set 5 : Mark histogram entries as unused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -816 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/dom_distiller/profile_utils.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/dom_distiller/profile_utils.cc View 1 chunk +21 lines, -29 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 2 3 2 chunks +4 lines, -31 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller_unittest.cc View 1 1 chunk +0 lines, -83 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/data/print_ticket_store.js View 2 chunks +0 lines, -12 lines 0 comments Download
D chrome/browser/resources/print_preview/data/ticket_items/distill_page.js View 1 chunk +0 lines, -63 lines 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 5 chunks +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/print_preview/preview_generator.js View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 4 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/print_preview/settings/other_options_settings.js View 10 chunks +3 lines, -67 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/webui/print_preview/print_preview_distiller.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/webui/print_preview/print_preview_distiller.cc View 1 chunk +0 lines, -293 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 7 chunks +4 lines, -33 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 2 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 2 3 chunks +1 line, -8 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/dom_distiller/core/css/distilledpage.css View 1 2 1 chunk +0 lines, -22 lines 0 comments Download
M components/dom_distiller/core/javascript/dom_distiller_viewer.js View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M printing/print_job_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M printing/print_job_constants.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
Lei Zhang
https://codereview.chromium.org/2108833002/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2108833002/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode136 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:136: DISTILL_PAGE, // UNUSED asvitkine: Should I modify the corresponding ...
4 years, 5 months ago (2016-06-28 19:00:38 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/2108833002/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2108833002/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode136 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:136: DISTILL_PAGE, // UNUSED On 2016/06/28 19:00:38, Lei Zhang wrote: ...
4 years, 5 months ago (2016-06-28 19:02:06 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm
4 years, 5 months ago (2016-06-28 20:38:14 UTC) #7
Lei Zhang
https://codereview.chromium.org/2108833002/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right): https://codereview.chromium.org/2108833002/diff/40001/chrome/browser/ui/webui/print_preview/print_preview_handler.cc#newcode136 chrome/browser/ui/webui/print_preview/print_preview_handler.cc:136: DISTILL_PAGE, // UNUSED On 2016/06/28 19:02:06, Alexei Svitkine (very ...
4 years, 5 months ago (2016-06-28 20:56:56 UTC) #8
wychen
The bug ID should be 620382.
4 years, 5 months ago (2016-06-29 05:38:55 UTC) #9
Lei Zhang
On 2016/06/29 05:38:55, wychen wrote: > The bug ID should be 620382. Updated.
4 years, 5 months ago (2016-06-29 06:08:16 UTC) #11
wychen
lgtm
4 years, 5 months ago (2016-06-29 17:57:53 UTC) #12
rkaplow
lgtm
4 years, 5 months ago (2016-06-29 18:17:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108833002/80001
4 years, 5 months ago (2016-06-29 18:21:15 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-06-29 18:30:40 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 18:30:56 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 18:31:58 UTC) #22
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/a223560fd493a9f25d23a33bd624328b6eec854a
Cr-Commit-Position: refs/heads/master@{#402876}

Powered by Google App Engine
This is Rietveld 408576698