Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/clang/plugins/tests/auto_raw_pointer.txt

Issue 2108823004: clang-plugins: Don't strip non const references in auto raw ptr fixits. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/auto_raw_pointer.txt
diff --git a/tools/clang/plugins/tests/auto_raw_pointer.txt b/tools/clang/plugins/tests/auto_raw_pointer.txt
index f42dfee94266b7c58a1ca29ccb6f77dbcd0dee02..34022bbf466d084346aa554c12d8942660064779 100644
--- a/tools/clang/plugins/tests/auto_raw_pointer.txt
+++ b/tools/clang/plugins/tests/auto_raw_pointer.txt
@@ -1,37 +1,53 @@
-auto_raw_pointer.cpp:17:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:22:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
auto raw_int_ptr = &integer;
^~~~
auto*
-auto_raw_pointer.cpp:18:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:23:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
const auto const_raw_int_ptr = &integer;
^~~~~~~~~~
auto* const
-auto_raw_pointer.cpp:19:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:24:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
const auto& const_raw_int_ptr_ref = &integer;
^~~~~~~~~~~
auto* const
-auto_raw_pointer.cpp:24:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:29:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
auto raw_foo_ptr = &foo;
^~~~
auto*
-auto_raw_pointer.cpp:25:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:30:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
const auto const_raw_foo_ptr = &foo;
^~~~~~~~~~
auto* const
-auto_raw_pointer.cpp:26:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:31:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
const auto& const_raw_foo_ptr_ref = &foo;
^~~~~~~~~~~
auto* const
-auto_raw_pointer.cpp:33:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:38:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
auto double_ptr_auto = &int_ptr;
^~~~
auto**
-auto_raw_pointer.cpp:34:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:39:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
auto* double_ptr_auto_ptr = &int_ptr;
^~~~~
auto**
-auto_raw_pointer.cpp:40:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+auto_raw_pointer.cpp:46:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
auto auto_awesome = pointer_awesomeness;
^~~~
auto* const* const volatile** const*
-9 warnings generated.
+auto_raw_pointer.cpp:48:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+ auto& int_ptr_ref = int_ptr;
+ ^~~~~
+ auto*&
+auto_raw_pointer.cpp:49:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+ const auto& const_int_ptr_ref = int_ptr;
+ ^~~~~~~~~~~
+ auto* const
+auto_raw_pointer.cpp:50:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+ auto&& int_ptr_rref = std::move(int_ptr);
+ ^~~~~~
+ auto*&&
+auto_raw_pointer.cpp:51:3: warning: [chromium-style] auto variable type must not deduce to a raw pointer type.
+ const auto&& const_int_ptr_rref = std::move(int_ptr);
+ ^~~~~~~~~~~~
+ auto* const
+13 warnings generated.

Powered by Google App Engine
This is Rietveld 408576698