fix #26122, classify strong mode errors correctly

fix #26122, classify strong mode errors correctly

StaticTypeWarningCode was being handled, but many warnings with StaticWarningCode also need to be treated as errors.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/1b9bf0769d3907c09955f54da64af70ddf070fc4

[Jennifer Messerly, 2016-06-28 19:18:28]

Description was changed from

==========
fix #26122, classify strong mode errors correctly
==========

to

==========
fix #26122, classify strong mode errors correctly

StaticTypeWarningCode was being handled, but many warnings with
StaticWarningCode also need to be treated as errors.
==========

[Jennifer Messerly, 2016-06-28 19:18:29]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com

[Jennifer Messerly, 2016-06-28 19:41:38]

Hi Brian,

This is to fix https://github.com/dart-lang/sdk/issues/26122 and lets DDC remove
its workaround (DDC changes: https://codereview.chromium.org/2102053003)

I was able to plug into the existing ErrorProcessor for strong mode, so I didn't
end up needing the custom strong mode logic in CLI/Server, hence restored that
code to how it used to be.

Thanks for the help earlier adding that isStrongModeError field :)
- John

[Brian Wilkerson, 2016-06-28 20:54:01]

lgtm

[Jennifer Messerly, 2016-06-28 21:35:45]

Description was changed from

==========
fix #26122, classify strong mode errors correctly

StaticTypeWarningCode was being handled, but many warnings with
StaticWarningCode also need to be treated as errors.
==========

to

==========
fix #26122, classify strong mode errors correctly

StaticTypeWarningCode was being handled, but many warnings with
StaticWarningCode also need to be treated as errors.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1b9bf0769d3907c09955f54da64af70ddf070fc4
==========

[Jennifer Messerly, 2016-06-28 21:35:46]

Committed patchset #2 (id:20001) manually as
1b9bf0769d3907c09955f54da64af70ddf070fc4 (presubmit successful).