Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2102053003: Remove DDC custom error list now that strong mode analyzer handles it (Closed)

Created:
4 years, 5 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove DDC custom error list now that strong mode analyzer handles it R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/d39946fd7af11d02a8831dbd7a2b776c69099ff6

Patch Set 1 #

Patch Set 2 : roll forward analyzer #

Patch Set 3 : another fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+653 lines, -606 lines) Patch
M lib/runtime/dart_sdk.js View 1 20 chunks +36 lines, -28 lines 0 comments Download
M lib/src/analyzer/context.dart View 1 2 8 chunks +6 lines, -15 lines 0 comments Download
D lib/src/analyzer/dart_sdk.dart View 1 2 1 chunk +0 lines, -207 lines 0 comments Download
M lib/src/compiler/compiler.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/compiler/error_helpers.dart View 1 2 2 chunks +1 line, -119 lines 0 comments Download
M pubspec.lock View 1 12 chunks +35 lines, -17 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/browser/language_tests.js View 1 4 chunks +4 lines, -3 lines 0 comments Download
M test/codegen_expected/corelib/collection_from_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/corelib/collection_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/has_next_iterator_test.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/corelib/hash_set_test_01_multi.js View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/hash_set_test_none_multi.js View 1 2 chunks +3 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/iterable_generate_test.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen_expected/corelib/iterable_join_test.js View 1 2 chunks +6 lines, -5 lines 0 comments Download
M test/codegen_expected/corelib/iterable_tostring_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/linked_hash_map_from_iterables_test.js View 1 3 chunks +7 lines, -6 lines 0 comments Download
M test/codegen_expected/corelib/list_fixed_test.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/list_insert_all_test.js View 1 2 chunks +7 lines, -6 lines 0 comments Download
M test/codegen_expected/corelib/list_insert_test.js View 1 1 chunk +105 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/list_removeat_test.js View 1 1 chunk +107 lines, -1 line 0 comments Download
M test/codegen_expected/corelib/list_replace_range_test.js View 1 3 chunks +13 lines, -12 lines 0 comments Download
M test/codegen_expected/corelib/list_set_all_test.js View 1 3 chunks +9 lines, -8 lines 0 comments Download
M test/codegen_expected/corelib/map_from_iterables_test.js View 1 3 chunks +7 lines, -6 lines 0 comments Download
M test/codegen_expected/corelib/shuffle_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/corelib/splay_tree_from_iterables_test.js View 1 3 chunks +7 lines, -6 lines 0 comments Download
M test/codegen_expected/language/async_star_test_01_multi.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_star_test_02_multi.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_star_test_03_multi.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_star_test_04_multi.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_star_test_05_multi.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/async_star_test_none_multi.js View 1 3 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/first_class_types_constants_test.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M test/codegen_expected/language/issue_23914_test.js View 1 1 chunk +4 lines, -2 lines 0 comments Download
M test/codegen_expected/language/recursive_inheritance_test.js View 1 1 chunk +1 line, -48 lines 0 comments Download
M test/codegen_expected/language/setter4_test.js View 1 1 chunk +1 line, -26 lines 0 comments Download
M test/codegen_expected/language/sync_generator2_test_none_multi.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M test/codegen_expected/language/type_error_test.js View 1 1 chunk +193 lines, -1 line 0 comments Download
M test/codegen_expected/lib/convert/chunked_conversion_utf88_test.js View 1 9 chunks +10 lines, -10 lines 0 comments Download
M test/codegen_expected/lib/html/canvasrenderingcontext2d_test.js View 1 8 chunks +8 lines, -8 lines 0 comments Download
M test/codegen_expected/lib/math/point_test.js View 1 2 chunks +18 lines, -18 lines 0 comments Download
M test/codegen_expected/lib/typed_data/typed_data_from_list_test.js View 1 1 chunk +3 lines, -3 lines 0 comments Download
M test/codegen_expected/lib/typed_data/typed_data_list_test.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen_expected/matcher/matcher.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/codegen_expected/stack_trace/stack_trace.js View 1 9 chunks +16 lines, -11 lines 0 comments Download
M test/codegen_expected/unittest/unittest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jennifer Messerly
this goes with the following Analyzer CL: https://codereview.chromium.org/2108823002/ I will need to roll to a ...
4 years, 5 months ago (2016-06-28 19:44:26 UTC) #2
Leaf
lgtm
4 years, 5 months ago (2016-06-28 22:34:34 UTC) #3
Jennifer Messerly
Hey Leaf, do you mind taking another look? This CL rolls DDC forward to a ...
4 years, 4 months ago (2016-07-27 17:50:46 UTC) #4
Jennifer Messerly
fyi - this gets a green Travis build: https://travis-ci.org/dart-lang/dev_compiler/builds/147823969
4 years, 4 months ago (2016-07-27 17:58:16 UTC) #5
Leaf
lgtm
4 years, 4 months ago (2016-07-27 20:00:03 UTC) #6
Jennifer Messerly
4 years, 4 months ago (2016-07-27 20:11:00 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d39946fd7af11d02a8831dbd7a2b776c69099ff6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698