Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2108803004: Add support for build category in BuildEvent (Closed)

Created:
4 years, 5 months ago by Sergiy Byelozyorov
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M infra/tools/send_monitoring_event/common.py View 3 chunks +6 lines, -1 line 0 comments Download
M infra_libs/event_mon/monitoring.py View 1 2 5 chunks +15 lines, -3 lines 0 comments Download
M infra_libs/event_mon/test/monitoring_test.py View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 52 (31 generated)
Sergiy Byelozyorov
4 years, 5 months ago (2016-06-29 21:33:18 UTC) #1
Sergey Berezin
lgtm
4 years, 5 months ago (2016-06-29 23:51:43 UTC) #2
Sergiy Byelozyorov
Made some changes after updating http://cl/126229322. PTAL
4 years, 5 months ago (2016-06-30 00:28:58 UTC) #3
Sergey Berezin (google)
https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/monitoring.py File infra_libs/event_mon/monitoring.py (right): https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/monitoring.py#newcode349 infra_libs/event_mon/monitoring.py:349: if category: nit: as an option, you can write ...
4 years, 5 months ago (2016-06-30 02:07:53 UTC) #5
Sergiy Byelozyorov
https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/monitoring.py File infra_libs/event_mon/monitoring.py (right): https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/monitoring.py#newcode349 infra_libs/event_mon/monitoring.py:349: if category: On 2016/06/30 02:07:53, Sergey Berezin (google) wrote: ...
4 years, 5 months ago (2016-07-06 08:55:30 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-06 08:55:52 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2795)
4 years, 5 months ago (2016-07-06 09:04:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-07 09:00:36 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: Infra Win Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/builds/2818)
4 years, 5 months ago (2016-07-07 09:09:43 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/100001
4 years, 5 months ago (2016-07-07 09:14:42 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/builds/2829)
4 years, 5 months ago (2016-07-07 09:22:33 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-08 11:09:04 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-08 11:10:24 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-08 11:12:19 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-08 11:15:13 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-08 11:16:52 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-08 11:25:46 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED, no ...
4 years, 5 months ago (2016-07-08 11:39:30 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108803004/80001
4 years, 5 months ago (2016-07-13 08:36:07 UTC) #49
commit-bot: I haz the power
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/infra/infra/+/c454ffb119edc355e22430622213ff95dd4012d5
4 years, 5 months ago (2016-07-13 08:50:31 UTC) #51
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:50:35 UTC) #52
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698