|
|
Created:
4 years, 5 months ago by Sergiy Byelozyorov Modified:
4 years, 5 months ago CC:
chromium-reviews, infra-reviews+infra_chromium.org Base URL:
https://chromium.googlesource.com/infra/infra.git@master Target Ref:
refs/heads/master Project:
infra Visibility:
Public. |
DescriptionAdd support for build category in BuildEvent
R=dsansome@chromium.org, sergeyberezin@chromium.org
BUG=596226
Committed: https://chromium.googlesource.com/infra/infra/+/c454ffb119edc355e22430622213ff95dd4012d5
Patch Set 1 #Patch Set 2 : Fix #
Total comments: 2
Patch Set 3 : Addressed comments #
Messages
Total messages: 52 (31 generated)
lgtm
Made some changes after updating http://cl/126229322. PTAL
sergeyberezin@google.com changed reviewers: + sergeyberezin@google.com
https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/mo... File infra_libs/event_mon/monitoring.py (right): https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/mo... infra_libs/event_mon/monitoring.py:349: if category: nit: as an option, you can write this as: category_map = { 'cq': BuildEvent.CATEGORY_CQ, 'cq_experimental': BuildEvent.CATEGORY_CQ_EXPERIMENTAL, 'git_cl_try': BuildEvent.CATEGORY_GIT_CL_TRY, } if category: event.build_event.category = category_map.get(category.lower(), BuildEvent.CATEGORY_UNKNOWN)
Patchset #3 (id:40001) has been deleted
Patchset #3 (id:60001) has been deleted
https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/mo... File infra_libs/event_mon/monitoring.py (right): https://codereview.chromium.org/2108803004/diff/20001/infra_libs/event_mon/mo... infra_libs/event_mon/monitoring.py:349: if category: On 2016/06/30 02:07:53, Sergey Berezin (google) wrote: > nit: as an option, you can write this as: > > category_map = { > 'cq': BuildEvent.CATEGORY_CQ, > 'cq_experimental': BuildEvent.CATEGORY_CQ_EXPERIMENTAL, > 'git_cl_try': BuildEvent.CATEGORY_GIT_CL_TRY, > } > if category: > event.build_event.category = category_map.get(category.lower(), > BuildEvent.CATEGORY_UNKNOWN) Thanks. I've made it even shorter.
The CQ bit was checked by sergiyb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)
Description was changed from ========== Add support for build category in BuildEvent COMMIT=false (http://cl/126229322 should land and get to production) R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ========== to ========== Add support for build category in BuildEvent R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ==========
The CQ bit was checked by sergiyb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyberezin@chromium.org Link to the patchset: https://codereview.chromium.org/2108803004/#ps80001 (title: "Addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Win Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Win%20Tester/bu...)
The CQ bit was checked by sergiyb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sergeyberezin@chromium.org Link to the patchset: https://codereview.chromium.org/2108803004/#ps100001 (title: "Fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Mac Tester on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Infra%20Mac%20Tester/bu...)
Patchset #4 (id:100001) has been deleted
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sergiyb@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sergiyb@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sergiyb@chromium.org
The CQ bit was checked by sergiyb@chromium.org
The CQ bit was unchecked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sergiyb@chromium.org
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sergiyb@chromium.org
The CQ bit was checked by sergiyb@chromium.org
The CQ bit was unchecked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Infra Linux Trusty 64 Tester on master.tryserver.infra (JOB_FAILED, no build URL)
Description was changed from ========== Add support for build category in BuildEvent R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ========== to ========== Add support for build category in BuildEvent COMMIT=false (depends on http://crrev.com/2138623002) R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ==========
Description was changed from ========== Add support for build category in BuildEvent COMMIT=false (depends on http://crrev.com/2138623002) R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ========== to ========== Add support for build category in BuildEvent R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ==========
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add support for build category in BuildEvent R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 ========== to ========== Add support for build category in BuildEvent R=dsansome@chromium.org, sergeyberezin@chromium.org BUG=596226 Committed: https://chromium.googlesource.com/infra/infra/+/c454ffb119edc355e22430622213f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/infra/infra/+/c454ffb119edc355e22430622213f...
Message was sent while issue was closed.
CQ bit was unchecked. |