Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2108783005: [ios] Implemented iOS analogue of SSLErrorHandler class. (Closed)

Created:
4 years, 5 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 5 months ago
Reviewers:
sdefresne, estark
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Implemented iOS analogue of SSLErrorHandler class. Currently on iOS SSL interstitials are presented in donwstream's Tab. This CL allows presenting them from WebClient::AllowCertificateError to be consistent with other platforms (where interstitials are presented from ContentBrowserClient::AllowCertificateError). Implementation of IOSSSLErrorHandler::HandleSSLError is even simpler than Tab code because the latter used to present Safe Browsing interstitials which can not be supported by WKWebView. BUG=602298 Committed: https://crrev.com/fbff955ad6b6f78b26582e896e5a79d0aaf4b2b8 Cr-Commit-Position: refs/heads/master@{#403288}

Patch Set 1 #

Patch Set 2 : Disabled gn test #

Total comments: 12

Patch Set 3 : Addressed review comments #

Patch Set 4 : Fixed test #

Total comments: 12

Patch Set 5 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -0 lines) Patch
M ios/chrome/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
A ios/chrome/browser/ssl/ios_ssl_error_handler.h View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
A ios/chrome/browser/ssl/ios_ssl_error_handler.mm View 1 2 3 4 1 chunk +47 lines, -0 lines 0 comments Download
A ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 37 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108783005/1
4 years, 5 months ago (2016-06-28 22:20:28 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/28329)
4 years, 5 months ago (2016-06-28 22:37:37 UTC) #4
Eugene But (OOO till 7-30)
Hi Emily, I would like to move iOS interstitials presentation code from Tab (downstream code) ...
4 years, 5 months ago (2016-06-29 16:56:41 UTC) #8
sdefresne
https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/ios_chrome_tests.gyp File ios/chrome/ios_chrome_tests.gyp (right): https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/ios_chrome_tests.gyp#newcode90 ios/chrome/ios_chrome_tests.gyp:90: '../../net/data/ssl/certificates/', On 2016/06/29 16:56:41, Eugene But wrote: > Sylvain, ...
4 years, 5 months ago (2016-06-29 17:10:03 UTC) #10
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/ios_chrome_tests.gyp File ios/chrome/ios_chrome_tests.gyp (right): https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/ios_chrome_tests.gyp#newcode90 ios/chrome/ios_chrome_tests.gyp:90: '../../net/data/ssl/certificates/', On 2016/06/29 17:10:03, sdefresne wrote: > On 2016/06/29 ...
4 years, 5 months ago (2016-06-29 17:44:38 UTC) #11
estark
Hi Eugene, I'm not very familiar with ios but I did my best! https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/browser/ssl/ios_ssl_error_handler.h File ...
4 years, 5 months ago (2016-06-29 23:00:15 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108783005/40001
4 years, 5 months ago (2016-06-29 23:28:55 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/29185)
4 years, 5 months ago (2016-06-29 23:41:58 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108783005/60001
4 years, 5 months ago (2016-06-29 23:47:03 UTC) #18
Eugene But (OOO till 7-30)
Thanks! PTAL https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/browser/ssl/ios_ssl_error_handler.h File ios/chrome/browser/ssl/ios_ssl_error_handler.h (right): https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/browser/ssl/ios_ssl_error_handler.h#newcode24 ios/chrome/browser/ssl/ios_ssl_error_handler.h:24: static void HandleSSLError(web::WebState* web_state, On 2016/06/29 23:00:15, ...
4 years, 5 months ago (2016-06-30 00:05:26 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 01:06:44 UTC) #21
sdefresne
https://codereview.chromium.org/2108783005/diff/60001/ios/chrome/browser/ssl/ios_ssl_error_handler.h File ios/chrome/browser/ssl/ios_ssl_error_handler.h (right): https://codereview.chromium.org/2108783005/diff/60001/ios/chrome/browser/ssl/ios_ssl_error_handler.h#newcode8 ios/chrome/browser/ssl/ios_ssl_error_handler.h:8: #include "base/callback.h" Can you instead include "base/callback_forward.h"? It should ...
4 years, 5 months ago (2016-06-30 11:58:16 UTC) #22
sdefresne
https://codereview.chromium.org/2108783005/diff/60001/ios/chrome/BUILD.gn File ios/chrome/BUILD.gn (right): https://codereview.chromium.org/2108783005/diff/60001/ios/chrome/BUILD.gn#newcode55 ios/chrome/BUILD.gn:55: # TODO(crbug.com/624450): Add this test back once gn build ...
4 years, 5 months ago (2016-06-30 12:01:17 UTC) #23
estark
lgtm https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/browser/ssl/ios_ssl_error_handler.h File ios/chrome/browser/ssl/ios_ssl_error_handler.h (right): https://codereview.chromium.org/2108783005/diff/20001/ios/chrome/browser/ssl/ios_ssl_error_handler.h#newcode24 ios/chrome/browser/ssl/ios_ssl_error_handler.h:24: static void HandleSSLError(web::WebState* web_state, On 2016/06/30 00:05:26, Eugene ...
4 years, 5 months ago (2016-06-30 17:02:05 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108783005/80001
4 years, 5 months ago (2016-06-30 17:47:12 UTC) #27
Eugene But (OOO till 7-30)
Thanks! https://codereview.chromium.org/2108783005/diff/60001/ios/chrome/BUILD.gn File ios/chrome/BUILD.gn (right): https://codereview.chromium.org/2108783005/diff/60001/ios/chrome/BUILD.gn#newcode55 ios/chrome/BUILD.gn:55: # TODO(crbug.com/624450): Add this test back once gn ...
4 years, 5 months ago (2016-06-30 18:35:58 UTC) #28
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-30 19:40:03 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2108783005/80001
4 years, 5 months ago (2016-06-30 21:07:05 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-06-30 21:14:53 UTC) #35
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 21:16:51 UTC) #37
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fbff955ad6b6f78b26582e896e5a79d0aaf4b2b8
Cr-Commit-Position: refs/heads/master@{#403288}

Powered by Google App Engine
This is Rietveld 408576698