Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm

Issue 2108783005: [ios] Implemented iOS analogue of SSLErrorHandler class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ssl/ios_ssl_error_handler.mm ('k') | ios/chrome/ios_chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm
diff --git a/ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm b/ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..013d8ad9e4adce6c8be8cfd9417b63d698126efa
--- /dev/null
+++ b/ios/chrome/browser/ssl/ios_ssl_error_handler_unittest.mm
@@ -0,0 +1,113 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ios/chrome/browser/ssl/ios_ssl_error_handler.h"
+
+#include "base/mac/bind_objc_block.h"
+#include "ios/chrome/browser/browser_state/test_chrome_browser_state.h"
+#include "ios/web/public/interstitials/web_interstitial.h"
+#import "ios/web/public/test/web_test_with_web_state.h"
+#import "ios/web/public/web_state/web_state.h"
+#include "net/ssl/ssl_info.h"
+#include "net/test/cert_test_util.h"
+#include "net/test/test_data_directory.h"
+
+namespace {
+const char kTestCertFileName[] = "ok_cert.pem";
+const char kTestHostName[] = "https://chromium.test/";
+} // namespace
+
+// Test fixture for IOSSSLErrorHandler class.
+class IOSSSLErrorHandlerTest : public web::WebTestWithWebState {
+ protected:
+ IOSSSLErrorHandlerTest()
+ : browser_state_(builder_.Build()),
+ cert_(net::ImportCertFromFile(net::GetTestCertsDirectory(),
+ kTestCertFileName)) {}
+
+ // web::WebTestWithWebState overrides:
+ void SetUp() override {
+ web::WebTestWithWebState::SetUp();
+ ASSERT_TRUE(cert_);
+ ASSERT_FALSE(web_state()->IsShowingWebInterstitial());
+ }
+ web::BrowserState* GetBrowserState() override { return browser_state_.get(); }
+
+ // Returns certificate for testing.
+ scoped_refptr<net::X509Certificate> cert() { return cert_; }
+
+ private:
+ TestChromeBrowserState::Builder builder_;
+ std::unique_ptr<TestChromeBrowserState> browser_state_;
+ scoped_refptr<net::X509Certificate> cert_;
+};
+
+// Tests non-overridable error handling.
+TEST_F(IOSSSLErrorHandlerTest, NonOverridable) {
+ net::SSLInfo ssl_info;
+ ssl_info.cert = cert();
+ GURL url(kTestHostName);
+ __block bool do_not_proceed_callback_called = false;
+ IOSSSLErrorHandler::HandleSSLError(
+ web_state(), net::ERR_CERT_AUTHORITY_INVALID, ssl_info, url, false,
+ base::BindBlock(^(bool proceed) {
+ EXPECT_FALSE(proceed);
+ do_not_proceed_callback_called = true;
+ }));
+
+ // Make sure that interstitial is displayed.
+ EXPECT_TRUE(web_state()->IsShowingWebInterstitial());
+ web::WebInterstitial* interstitial = web_state()->GetWebInterstitial();
+ EXPECT_TRUE(interstitial);
+
+ // Make sure callback is called on dismissal.
+ interstitial->DontProceed();
+ EXPECT_TRUE(do_not_proceed_callback_called);
+}
+
+// Tests proceed with overridable error.
+TEST_F(IOSSSLErrorHandlerTest, OverridableProceed) {
+ net::SSLInfo ssl_info;
+ ssl_info.cert = cert();
+ GURL url(kTestHostName);
+ __block bool proceed_callback_called = false;
+ IOSSSLErrorHandler::HandleSSLError(
+ web_state(), net::ERR_CERT_AUTHORITY_INVALID, ssl_info, url, true,
+ base::BindBlock(^(bool proceed) {
+ EXPECT_TRUE(proceed);
+ proceed_callback_called = true;
+ }));
+
+ // Make sure that interstitial is displayed.
+ EXPECT_TRUE(web_state()->IsShowingWebInterstitial());
+ web::WebInterstitial* interstitial = web_state()->GetWebInterstitial();
+ EXPECT_TRUE(interstitial);
+
+ // Make sure callback is called on dismissal.
+ interstitial->Proceed();
+ EXPECT_TRUE(proceed_callback_called);
+}
+
+// Tests do not proceed with overridable error.
+TEST_F(IOSSSLErrorHandlerTest, OverridableDontProceed) {
+ net::SSLInfo ssl_info;
+ ssl_info.cert = cert();
+ GURL url(kTestHostName);
+ __block bool do_not_proceed_callback_called = false;
+ IOSSSLErrorHandler::HandleSSLError(
+ web_state(), net::ERR_CERT_AUTHORITY_INVALID, ssl_info, url, true,
+ base::BindBlock(^(bool proceed) {
+ EXPECT_FALSE(proceed);
+ do_not_proceed_callback_called = true;
+ }));
+
+ // Make sure that interstitial is displayed.
+ EXPECT_TRUE(web_state()->IsShowingWebInterstitial());
+ web::WebInterstitial* interstitial = web_state()->GetWebInterstitial();
+ EXPECT_TRUE(interstitial);
+
+ // Make sure callback is called on dismissal.
+ interstitial->DontProceed();
+ EXPECT_TRUE(do_not_proceed_callback_called);
+}
« no previous file with comments | « ios/chrome/browser/ssl/ios_ssl_error_handler.mm ('k') | ios/chrome/ios_chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698